A bug in android-sync tool

[bang...@gmail.com]

Hi,

I noticed a bug in android-sync.sh, which caused the android_arm.release.check unittests crash on device. It is fixed by adding:

sync_file "$OUTDIR/$ARCH_MODE/natives_blob.bin"

sync_file "$OUTDIR/$ARCH_MODE/snapshot_blob.bin"

I would like to upload the changes, but it failed to create CL. Here is the error message:

v8$> git cl upload

Using 50% similarity for rename/copy detection. Override with --similarity.

You are not logged in. Please login first by running:

  depot-tools-auth login https://codereview.chromium.org

But I did login before trying to upload and I also had CLA two years ago.

Can anyone please show me what's gone wrong?

Thanks in advance.

Bangfu

 

[Yang Guo]

Hi Bangfu,

This looks like a necessary change, Thanks! Daniel, Ulan, does this look right to you guys?

While I have no clue what may be wrong with the depot tools authentication, I cannot confirm that you have signed the CL with your address "bang...@gmail.com". Would it be alright with you if we land the change on your behalf and credit you in the commit message once you signed the CLA (again even if you already did)?

Regards,

Yang

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Bangfu Tao]

Hi Yang,

Thank you, that's fine if you can make the change for me.

In CLA, it's bangf...@samsung.com. But I tried both IDs, neither of them worked.

Thanks

Bangfu

You received this message because you are subscribed to a topic in the Google Groups "v8-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/v8-dev/uXhjHPoT7rc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to v8-dev+un...@googlegroups.com.

[Yang Guo]

Yup. I can confirm that address for having signed the CLA.

[Daniel Vogelheim]

On Thu, Jan 21, 2016 at 10:36 AM, Yang Guo <yan...@chromium.org> wrote:

This looks like a necessary change, Thanks! Daniel, Ulan, does this look right to you guys?

The change looks good, assuming that sync_file does nothing if the source file doesn't exist.

The default build now uses the two *_blob.bin files, but this can be disabled. So there can still be builds without either *_blob.bin, and in that case the sync script should still work.

[Jochen Eisinger]

can you login with your samsung address on codereview.chromium.org? If not, did you ever create a google account for that address?

best

-jochen

[Bangfu Tao]

Hi Jochen,

I can also login with Samsung address on codereview.chromium.org. 

Just wondering, do I need to do "git cl config"? If yes, please show me how to.

Thanks

Bangfu

You received this message because you are subscribed to a topic in the Google Groups "v8-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/v8-dev/uXhjHPoT7rc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to v8-dev+un...@googlegroups.com.

[Jochen Eisinger]

you should run 

depot-tools-auth login https://codereview.chromium.org

on the command line. If this opens in a different browser session than the one where you're logged into codereview.chromium.org, just copy the URL over to the codereview.chromium.org window and approve access.

Then you should be able to use git cl upload