[minor] conversions.cc spec references may require updating

7 views
Skip to first unread message

richi...@gmail.com

unread,
May 2, 2019, 6:57:16 PM5/2/19
to v8-dev
Quick reference: conversions.cc

L170 on "// ES6 18.2.5 parseInt(string, radix) " points to the correct section in the spec, but scrolling down to L370 "ParseInternal", there are the comments referring to section 15.1.2.2 (i.e., "if R is not 2, 4, 6, 8, 10..."). This spec is now in 18.2.5.13 for ECMA2018 (and for the ECMA2020 draft)



Yang Guo

unread,
May 3, 2019, 2:35:16 AM5/3/19
to v8-...@googlegroups.com
Contributions to fix this are welcome. I suspect that the sections referred to in the comments have ES6 as context.

Yang

On Fri, May 3, 2019 at 12:57 AM <richi...@gmail.com> wrote:
Quick reference: conversions.cc

L170 on "// ES6 18.2.5 parseInt(string, radix) " points to the correct section in the spec, but scrolling down to L370 "ParseInternal", there are the comments referring to section 15.1.2.2 (i.e., "if R is not 2, 4, 6, 8, 10..."). This spec is now in 18.2.5.13 for ECMA2018 (and for the ECMA2020 draft)



--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Richard Schloss

unread,
May 3, 2019, 2:48:17 AM5/3/19
to v8-...@googlegroups.com
Ok, thanks for your help and clarification

You received this message because you are subscribed to a topic in the Google Groups "v8-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/v8-dev/uHCRMMl_EJ0/unsubscribe.
To unsubscribe from this group and all its topics, send an email to v8-dev+un...@googlegroups.com.
Reply all
Reply to author
Forward
Message has been deleted
0 new messages