PSA: Gerrit is becoming V8's default codereview tool today!

25 views
Skip to first unread message

Aaron Gable

unread,
Jun 30, 2017, 12:55:41 PM6/30/17
to v8-...@googlegroups.com, Michael Achenbach, Julie Parent, Andrew Bonventre
Hey V8 devs,

It's been a while since we enabled Gerrit for V8. In that time, we've made a bunch of improvements: editing the commit message is now just as fast as Rietveld, you can reland old submitted changes if they've been reverted, typing "lgtm" as the first word of your message will approve the change, and more. And in that time, use of Gerrit in V8 has organically grown to be over 80% of all commits in the last month:

± git log --oneline --since 2017/06/01 | wc -l                     
702
± git log --oneline --since 2017/06/01 --grep 'Reviewed-on' | wc -l
571
± bc -l <<< "571 / 702 * 100"
81.34

So with that milestone behind us, the upcoming default switch for chromium, and machenbach's enthusiasm, we're flipping the default for V8 today!

Once the default changes, any changes that you already have under review on Rietveld will of course continue to upload to Rietveld. If you need an escape hatch for any reason, you can use `git cl upload --rietveld` to bypass the default, and then please file a bug letting us know why you couldn't use Gerrit for that change.

After a few week (but well before the end of Q3) we'll also mark Rietveld read-only for V8, so it will refuse all uploads of new changes. Another PSA will be forthcoming at that time.

As always, if you have any questions, please consult the FAQ. If you have any problems with 'git cl upload', file a bug here; if you have any problems with the Gerrit web interface, file a bug here.

Thanks,
Aaron
Reply all
Reply to author
Forward
0 new messages