V8 Changes can now be reviewed on Gerrit!

[Aaron Gable]

Hey V8 devs,

tl;dr: Upload changes to gerrit using "git cl upload --gerrit". File bugs here. We hope to make Gerrit the default on Thursday, Feb 16th, assuming we don't uncover any blockers before then.

As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.

As part of that process, we'd like to invite you all to dogfood using Gerrit for your code reviews.

The following instructions apply only to the main V8 repository.

To upload a change to Gerrit instead of Rietveld, just run

  `git cl upload --gerrit`

when uploading the change for the first time. Additional patchsets after the first will automatically upload to the same review. If you would like all of your reviews to go to Gerrit without having to pass the flag, simply run

  `git config --local gerrit.host true`

in your local repository checkout.

While using Gerrit, please make sure that you are using the newer Polymer-based PolyGerrit UI. You should be using it by default, but if not, you can switch between UIs using the "New UI" link in the footer of every page.

This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infr...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

In a few weeks, assuming things are working smoothly, we will switch the default so that all reviews will go to Gerrit, and you'll no longer need to pass the --gerrit flag. At this time, we expect that switch date to be Thursday, Feb 16th. Depending on feedback, we obviously may delay that date. We'll ask for your feedback and communicate the timeline for that flag change clearly, and you can track the work towards it here:

https://bugs.chromium.org/p/chromium/issues/detail?id=685318

Thanks,

Aaron

[tan...@chromium.org]

Update: V8 contributors with try job access who are not yet v8 committers can now use CQ in Gerrit

You can ask CQ to perform "dry run" by pressing a corresponding button or replying with "CQ+1".

Once you get approval from a committer (Code-Review+1), you can press "Submit to CQ" button to test and commit your changelist.

Please, try it and let us know if you had any issues with it by filing bugs here.

Thanks,

Andrii

On Thursday, February 2, 2017 at 7:06:57 PM UTC+1, Aaron Gable wrote:

Hey V8 devs,

tl;dr: Upload changes to gerrit using "git cl upload --gerrit". File bugs here. We hope to make Gerrit the default on Thursday, Feb 16th, assuming we don't uncover any blockers before then.

As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.

As part of that process, we'd like to invite you all to dogfood using Gerrit for your code reviews.

The following instructions apply only to the main V8 repository.

To upload a change to Gerrit instead of Rietveld, just run

  `git cl upload --gerrit`

when uploading the change for the first time. Additional patchsets after the first will automatically upload to the same review. If you would like all of your reviews to go to Gerrit without having to pass the flag, simply run

  `git config --local gerrit.host true`

in your local repository checkout.

While using Gerrit, please make sure that you are using the newer Polymer-based PolyGerrit UI. You should be using it by default, but if not, you can switch between UIs using the "New UI" link in the footer of every page.

This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infra+polyg...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

[Michael Achenbach]

Update: The scripts for merging commits to branches will use Gerrit by default now.

This affects merge_to_branch.py and roll_merge.py. If you find any problems, please file bugs here and/or fall back to the old behavior by passing --rietveld to the scripts.

Cheers

Michael

On Tue, Feb 14, 2017 at 4:33 PM, <tan...@chromium.org> wrote:

Update: V8 contributors with try job access who are not yet v8 committers can now use CQ in Gerrit

You can ask CQ to perform "dry run" by pressing a corresponding button or replying with "CQ+1".

Once you get approval from a committer (Code-Review+1), you can press "Submit to CQ" button to test and commit your changelist.

Please, try it and let us know if you had any issues with it by filing bugs here.

Thanks,

Andrii

On Thursday, February 2, 2017 at 7:06:57 PM UTC+1, Aaron Gable wrote:

Hey V8 devs,

tl;dr: Upload changes to gerrit using "git cl upload --gerrit". File bugs here. We hope to make Gerrit the default on Thursday, Feb 16th, assuming we don't uncover any blockers before then.

As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.

As part of that process, we'd like to invite you all to dogfood using Gerrit for your code reviews.

The following instructions apply only to the main V8 repository.

To upload a change to Gerrit instead of Rietveld, just run

  `git cl upload --gerrit`

when uploading the change for the first time. Additional patchsets after the first will automatically upload to the same review. If you would like all of your reviews to go to Gerrit without having to pass the flag, simply run

  `git config --local gerrit.host true`

in your local repository checkout.

While using Gerrit, please make sure that you are using the newer Polymer-based PolyGerrit UI. You should be using it by default, but if not, you can switch between UIs using the "New UI" link in the footer of every page.

This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infra+polygerri...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

In a few weeks, assuming things are working smoothly, we will switch the default so that all reviews will go to Gerrit, and you'll no longer need to pass the --gerrit flag. At this time, we expect that switch date to be Thursday, Feb 16th. Depending on feedback, we obviously may delay that date. We'll ask for your feedback and communicate the timeline for that flag change clearly, and you can track the work towards it here:

https://bugs.chromium.org/p/chromium/issues/detail?id=685318

Thanks,

Aaron

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.