--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/b5bf5bce-37ca-4cbf-bc1c-81d0f259e74en%40googlegroups.com.
Hmm, we implemented your suggestion and so far have NOT encountered any issues on 10.7. We had definitely tried the same thing on 10.6 and encountered crashes, but we may have misinterpreted our results.Interestingly, there does appear to be code that dereferences the return value without checking for nullptr, but it could be a red herring.
In any case, since we can't repro any crashes at the moment, please feel free to ignore this question. Sorry about that!BTW, the change you linked reads "All embedders override this method now, so it can be abstract." Question: To whom does "all embedders" refer? :)
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/079ea899-db7c-4534-a7fb-51b984744b19n%40googlegroups.com.
On Tue, Oct 18, 2022 at 9:28 PM ClearScript Developers <clearsc...@gmail.com> wrote:Hmm, we implemented your suggestion and so far have NOT encountered any issues on 10.7. We had definitely tried the same thing on 10.6 and encountered crashes, but we may have misinterpreted our results.Interestingly, there does appear to be code that dereferences the return value without checking for nullptr, but it could be a red herring.That's in cppgc code, which in my understanding isn't directly used by V8 (in Chromium it implements the garbage collector used for objects on the Oilpan heap).
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAEvLGcJyJgiwUrxzkfO57X58ikw_27KB6%3DYia-p1kX%3D%2BOUMqiw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAH%2BmL5CTft-Dvjyd637GXez70sLLMHwwtjfYvCQXJO0uMxbaGQ%40mail.gmail.com.