Native MSVC Building Patch (VCPKG)

[Rodrigo Hernandez]

Hello,

I did some work to build V8 as a VCPKG package and so far I had just created patches to be used as part of the build, the VCPKG maintainers have constantly asked me to push the changes upstream and since the update process is quite complicated and that they may no longer accept any changes as the patches become larger, I finally decided to upload a patch:

https://chromium-review.googlesource.com/c/v8/v8/+/3584330

This is just the v8 part, there is need to add changes to build, icu and zlib, which I guess would have to be done as a Chromium change... or is there another way?

Best,

R.

[Jakob Gruber]

On Tue, Apr 12, 2022 at 10:50 PM Rodrigo Hernandez <kwizatz.ae...@gmail.com> wrote:

Hello,

I did some work to build V8 as a VCPKG package and so far I had just created patches to be used as part of the build, the VCPKG maintainers have constantly asked me to push the changes upstream and since the update process is quite complicated and that they may no longer accept any changes as the patches become larger, I finally decided to upload a patch:

https://chromium-review.googlesource.com/c/v8/v8/+/3584330

Thanks, fyi you'll have to mark the CL as active and add reviewers for something to happen.

 

This is just the v8 part, there is need to add changes to build, icu and zlib, which I guess would have to be done as a Chromium change... or is there another way?

I assume you'll have to upstream these changes in the source repos (icu, zlib, ...), yes.

 

Best,

R.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/d08ad7c3-28a7-4d7f-8557-1f12ebe269aan%40googlegroups.com.

[Rodrigo Hernandez]

Yeah, there's 3 PRs but I need to move discussion to chromium-dev for 2 of them to merge first since they touch build. 😢

I'll post there during the weekend, but somehow I don't feel like the changes will be welcome, they're not exactly trivial, though I did my best not to insert regressions.