github org repo for vim-torque

28 views
Skip to first unread message

Gus Caplan

unread,
May 19, 2020, 1:23:03 PM5/19/20
to v8-dev
I'm not exactly sure what the process is here, but I'd like to move v8/tools/torque/vim-torque into its own org repo like https://github.com/v8/vscode-torque.

Yang Guo

unread,
May 19, 2020, 1:32:58 PM5/19/20
to v8-...@googlegroups.com
For setting up new repositories under Google properties, Google has an internal launch process that needs to go through a checklist of approvals. It's usually fairly painless, but can take a week or two. Best to find someone on the V8 team to help you get this underway?

Yang

On Tue, May 19, 2020, 19:23 Gus Caplan <fluffyro...@gmail.com> wrote:
I'm not exactly sure what the process is here, but I'd like to move v8/tools/torque/vim-torque into its own org repo like https://github.com/v8/vscode-torque.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/8167aabe-5e72-41f1-b7bb-4604d09edac1%40googlegroups.com.

Gus Caplan

unread,
May 19, 2020, 1:48:50 PM5/19/20
to v8-dev
Indeed, I was posting here hoping someone on the V8 team could help out.


On Tuesday, 19 May 2020 12:32:58 UTC-5, Yang Guo wrote:
For setting up new repositories under Google properties, Google has an internal launch process that needs to go through a checklist of approvals. It's usually fairly painless, but can take a week or two. Best to find someone on the V8 team to help you get this underway?

Yang

On Tue, May 19, 2020, 19:23 Gus Caplan <fluffyro...@gmail.com> wrote:
I'm not exactly sure what the process is here, but I'd like to move v8/tools/torque/vim-torque into its own org repo like https://github.com/v8/vscode-torque.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-...@googlegroups.com.

Adam Klein

unread,
May 19, 2020, 2:42:55 PM5/19/20
to v8-...@googlegroups.com, te...@chromium.org
Directly CCing Tobias, who's generally responsible for all-things-Torque.

To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/0b1f9bd0-962b-4381-b530-521606334050%40googlegroups.com.

Tobias Tebbi

unread,
May 20, 2020, 11:54:50 AM5/20/20
to Adam Klein, v8-...@googlegroups.com
I'm happy to help, but I don't know yet how this works ... I'll figure it out.
For vscode-torque, the motivation to move it out of the repo was to put it on the VSCode marketplace.
Is there a similar motivation for the Vim plugin? I'm quite happy to approve patches or new features
for the Vim plugin even if it stays in the V8 source tree.

Gus Caplan

unread,
May 22, 2020, 9:14:33 AM5/22/20
to v8-dev
Vim plugin managers are usually able to directly install git repos and keep themselves updated, but I don't know of any which support the plugin being in a subdirectory of the git repository.

Tobias Tebbi

unread,
May 26, 2020, 9:04:57 AM5/26/20
to v8-...@googlegroups.com
I looked into it and it's a lot of bureaucracy to get a new repo approved. Given that whenever you write Torque, there has to be a V8 checkout, it should be possible to let vim get the plugin right from this local folder. That should be about as good as automatic updates. Does this work for you?

Am Fr., 22. Mai 2020 um 15:14 Uhr schrieb Gus Caplan <fluffyro...@gmail.com>:
Vim plugin managers are usually able to directly install git repos and keep themselves updated, but I don't know of any which support the plugin being in a subdirectory of the git repository.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.

Leszek Swirski

unread,
May 26, 2020, 9:34:06 AM5/26/20
to v8-dev
FWIW, I believe vim-plug lets you specify a subdirectory with 'rtp', so something like this might work:

Plug 'v8/v8', { 'rtp': '/tools/torque/vim-torque' }

Gus Caplan

unread,
May 26, 2020, 1:30:37 PM5/26/20
to v8-dev
It will definitely be usable if it stays in tree. There is a bit of annoyance in checking out an old revision and your highlighting getting messed up but that's not the end of the world.


On Tuesday, 26 May 2020 08:04:57 UTC-5, Tobias Tebbi wrote:
I looked into it and it's a lot of bureaucracy to get a new repo approved. Given that whenever you write Torque, there has to be a V8 checkout, it should be possible to let vim get the plugin right from this local folder. That should be about as good as automatic updates. Does this work for you?

Am Fr., 22. Mai 2020 um 15:14 Uhr schrieb Gus Caplan <fluffyro...@gmail.com>:
Vim plugin managers are usually able to directly install git repos and keep themselves updated, but I don't know of any which support the plugin being in a subdirectory of the git repository.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-...@googlegroups.com.

Gus Caplan

unread,
May 26, 2020, 1:31:23 PM5/26/20
to v8-dev
Thanks for the info. I'm not sure I can use that with my setup but it is good to know.


On Tuesday, 26 May 2020 08:34:06 UTC-5, Leszek Swirski wrote:
FWIW, I believe vim-plug lets you specify a subdirectory with 'rtp', so something like this might work:

Plug 'v8/v8', { 'rtp': '/tools/torque/vim-torque' }

On Tue, May 26, 2020 at 3:05 PM Tobias Tebbi <te...@chromium.org> wrote:
I looked into it and it's a lot of bureaucracy to get a new repo approved. Given that whenever you write Torque, there has to be a V8 checkout, it should be possible to let vim get the plugin right from this local folder. That should be about as good as automatic updates. Does this work for you?

Am Fr., 22. Mai 2020 um 15:14 Uhr schrieb Gus Caplan <fluffyro...@gmail.com>:
Vim plugin managers are usually able to directly install git repos and keep themselves updated, but I don't know of any which support the plugin being in a subdirectory of the git repository.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-...@googlegroups.com.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages