[cppgc] CppgcTracingScopesTest.DisabledScope fails when using standalone cppgc

18 views
Skip to first unread message

Cheng

unread,
Oct 22, 2024, 4:41:12 AM10/22/24
to v8-dev
I maintain a standalone version of cppgc and the test CppgcTracingScopesTest.DisabledScope has started failing with following change:
https://chromium.googlesource.com/v8/v8.git/+/8b9410819e0bed1e300b3f30bbca93aa65604f18

I understand it is not something V8 team supports but I would really appreciate a hint on what might be wrong and how can I fix it.

To test with my standalone version of cppgc:

git clone -b update-latest-cppgc https://github.com/compilets/cppgc
gn gen out/Debug --args='is_debug=true'
ninja -C out/Debug cppgc_unittests
./out/Debug/cppgc_unittests


Thanks,
Cheng

Michael Lippautz

unread,
Oct 22, 2024, 4:49:01 AM10/22/24
to v8-...@googlegroups.com
Can you file a bug at https://crbug.com/new? You can cc me.

The build is generally not the highest priority for us but we do intend to keep the tests clean and your output suggests that this is also broken on our end.

-Michael 

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/1ebb27cf-90cb-4e1e-82a6-624a3ac43d84n%40googlegroups.com.

Cheng

unread,
Oct 22, 2024, 6:12:15 AM10/22/24
to v8-dev
Thanks for looking into this, I have created https://issues.chromium.org/issues/374811616, I can't cc people in the issue.

Omer Katz (chromium.org)

unread,
Oct 22, 2024, 7:02:30 AM10/22/24
to v8-...@googlegroups.com
Thanks for the bug. I'll take a look.

Reply all
Reply to author
Forward
0 new messages