Remove the workaround for gcc bug.43949?

[Chandler]

Hi ,

I notice there is a trivial workaround for gcc bug.43949:

https://chromium.googlesource.com/v8/v8.git/+/refs/heads/main/src/execution/arm/simulator-arm.cc

int32_t Simulator::get_register(int reg) const {
DCHECK((reg >= 0) && (reg < num_registers));
// Stupid code added to avoid bug in GCC.
// See: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43949
if (reg >= num_registers) return 0;
// End stupid code.
return registers_[reg] + ((reg == pc) ? Instruction::kPcLoadDelta : 0);
}

this compiler bug is marked as fixed:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43949
Shall this workaround be removed? Is the bug actually fixed？

[Clemens Backes]

This code is from 2010, and I agree that it's not needed any more and can be removed. Feel free to upload a CL (https://v8.dev/docs/contribute).

Is there a particular reason that you want these lines to be removed?

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/043adcbf-501c-4aaf-afbd-8df419f2c7den%40googlegroups.com.

--

Clemens Backes

Software Engineer

clem...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian   

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.