Need help with a patch review (first contribution)

[John Paul Adrian Glaubitz]

Hello!

I have submitted my first patch for V8 a little over a week ago and I'm wondering
whether there is anything I may have missed which is why my submission isn't
getting any attention.

My submission can be found here and it looks like I may have to add the relevant
code owner before the patch can be reviewed?

> https://chromium-review.googlesource.com/c/v8/v8/+/4124995

Or is the code owner determined automatically?

Sorry if the answer may sound obvious, I'm new here ;-).

Thanks,
Adrian

[Manos Koukoutos]

Hi there,

you have to select a reviewer from among the owners of each file you modified, under Reply -> Show all owners. I added the author of the original CL +Clemens Backes for you.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/d754c4f2-fc15-b9a4-cba5-d10e7a70b605%40googlemail.com.

[Thibaud Michaud]

Also note that the reviewers will only get notified once you click "Start review". The state should change from "Work in Progress" to "Active" (top left).

To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAKgH8943rB-8pomTPQwJnO6tOMcCJJH24rDzzQJbhZfMBb%2B3Pg%40mail.gmail.com.