GDB Server Patch

[Albert Slepak]

Dear V8 Project Maintainers,

I noticed that in the current builds, if you use the "v8_enable_wasm_gdb_remote_debugging = true" flag, wasm gdb server code produces compiler errors and fails to build. I have made a patch that I would like to submit that updated the gdb server code and tests to be up to date and pass.
This is my first time contributing to v8, so could you please advise me on how to proceed and if there's anything else needed?

Thank you for your time.

Best,
Albert

[Ho Cheung]

Hello, please see https://v8.dev/docs/contribute to learn more about how to contribute code to V8.

[Albert Slepak]

Hi, I read through the docs on how to contribute and made sure my patch passes the linter.
Since the docs suggested to post here as the first step, I wanted to do this first before proceeding to submitting the code for review.
Am I good to proceed or is there anything else I should do first?

Sincerely,
Albert Slepak

[Marja Hölttä]

If you have signed the CLA, you're good to go! 

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian.

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.

    

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/v8-dev/3f429900-72a4-41e5-ac64-98ce60dceac8n%40googlegroups.com.

[Ho Cheung]

You can file a report on crbug, describing the problem you are currently facing and the solution, etc., and then you can submit the code for review.

https://issues.chromium.org/issues/new?noWizard=true&component=1456824&template=2109136

--

--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---

You received this message because you are subscribed to a topic in the Google Groups "v8-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/v8-dev/Otex7dyxGcw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to v8-dev+un...@googlegroups.com.

[Albert Slepak]

Thank you for the support and instructions. I signed the CLA and filed a bug report. All the presubmit checks ran fine as well,
but when I try to git cl upload, I keep getting the 401 Unauthorized error even though "git cl creds-check" returned no errors and credential-luci login command succeeded as well.
What could be the problem?

[Albert Slepak]

Just to follow up, I have submitted the patch for review: https://chromium-review.googlesource.com/c/v8/v8/+/6785387
Please let me know if anything else is needed.