CL is stuck in "Work in Progress" after following Code Review guide

[Jan Krems]

Hello everyone,

After a longer time I tried submitting another patch to V8, following the guide on v8.dev and the linked Chromium guide to request a review. But after selecting reviewers and clicking "Send", the CL is still in "Work in Progress", warning that reviewers won't be notified. Is there a step I missed?

The CL in question is https://chromium-review.googlesource.com/c/v8/v8/+/1995312.

Cheers,

Jan

[Santiago Aboy Solanes]

There's supposed to be a "send", and a "start review" button. Click "start review".

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/f3302419-5fe9-4c63-9ef7-bdef82760918%40googlegroups.com.

[Jan Krems]

Hah, thanks. Turns out I accidentally created the CL using my Google account instead of the personal one I used in the past. So my personal account wasn't allowed to ask for the review, unsurprisingly... Sorry for the noise. :)

To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAFKEYJgoWQzcPYus2L9xF_qQdwJYWSo345F2n7DtDeM%2B-2fQ9Q%40mail.gmail.com.

--

Jan Krems |

Software Engineer |

jank...@google.com |

6504228673