PSA: Avoid GetHeapFromWritableObject and friends

39 views
Skip to first unread message

Clemens Backes

unread,
Feb 18, 2025, 4:39:35 AM2/18/25
to v8-dev
We will have to remove most (or all) calls to GetHeapFromWritableObject and its callers (in particular all the Object::GetHeap() and Object::GetIsolate() methods) to ensure sandbox safety. The alternative is reading the current isolate from TLS via Isolate::Current().

See the design doc for details.

--

Clemens Backes

Software Engineer

clem...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München


Geschäftsführer: Paul Manicle, Liana Sebastian   

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg


Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.


This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.


David Archuleta Jr.

unread,
Feb 18, 2025, 10:15:59 AM2/18/25
to v8-...@googlegroups.com
I wonder if it is possible to get access to that design doc? Or make it public?

Best,
David

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/v8-dev/CAGO%3DqhD%3DMTQrKgmDbWM5KCmOuXxOv-cOmTs4EFfuMY1f51pLuA%40mail.gmail.com.

Clemens Backes

unread,
Feb 18, 2025, 10:22:42 AM2/18/25
to v8-...@googlegroups.com
On Tue, Feb 18, 2025 at 4:16 PM David Archuleta Jr. <darchu...@gmail.com> wrote:
I wonder if it is possible to get access to that design doc? Or make it public?

Yes, and no. I grant commenter access to anyone requesting it. The document is already commentable by all chromium and Google members. I cannot make it any more public without copying it (because I created it from my google.com account), and at this point I want to avoid this because that would start a new document.
 

David Archuleta Jr.

unread,
Feb 18, 2025, 10:25:34 AM2/18/25
to v8-...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages