looks like a bug in either uffs_FormatDevice or uffs_format

[bowerymarc]

uffs_format calls uffs_FormatDevice - both call uffs_GlobalFsLockLock causing a system hang.

I'd opt for removing the lock from uffs_format (uffs_fd.c)

thoughts?

[Ricky Zheng]

Yes that would hang the system if the lock not allow reentrant. I'll fix that.

Cheers,

Ricky.

--
You received this message because you are subscribed to the Google Groups "UFFS" group.
To unsubscribe from this group and stop receiving emails from it, send an email to uffs+uns...@googlegroups.com.
To post to this group, send email to uf...@googlegroups.com.
Visit this group at http://groups.google.com/group/uffs.
For more options, visit https://groups.google.com/groups/opt_out.

[bowerymarc]

I had implemented lock with a binary semaphore - should it be a reference counting semaphore? I think that's available in the system if that's what's recommended - but binary semaphores are generally less code, if it's not really necessary (which in this case it looks like it isn't if the lock in uffs_fd.c is eliminated). Thoughts?

[Ricky Zheng]

Binary semaphore should be enough.

Cheers,

Ricky.

On Fri, Oct 18, 2013 at 1:14 AM, bowerymarc <bower...@gmail.com> wrote:

I had implemented lock with a binary semaphore - should it be a reference counting semaphore?  I think that's available in the system if that's what's recommended - but binary semaphores are generally less code, if it's not really necessary (which in this case it looks like it isn't if the lock in uffs_fd.c is eliminated).  Thoughts?