SVN::GetRootAndHead

[Daniel Sahlberg]

Hi,

In the users group, a user reported an error when starting View log from the repobrowser using a peg revision if the file had subsequently been deleted, see [1].

I have investigated and it seems SVN::GetRootAndHead is calling GetHeadRevision with a path (which potentially is deleted and thus the repository will return an error). A few lines above, the code has retrieved the root URL.

I've tried the following patch which seems to resolve the issue.

[[[

Index: SVN/SVN.cpp
===================================================================
--- SVN/SVN.cpp (revision 29681)
+++ SVN/SVN.cpp (working copy)
@@ -2806,7 +2806,7 @@
         }
         else
         {
-            rev = cachedProperties.GetHeadRevision(uuid, path);
+            rev = cachedProperties.GetHeadRevision(uuid, url);
             if ((rev == NO_REVISION) && (m_err == nullptr))
             {
                 CHooks::Instance().PreConnect(CTSVNPathList(path));

]]]

Any comments?

Kind regards,

Daniel

[1] https://groups.google.com/g/tortoisesvn/c/N2bp4hyLRI8/m/8MlT8yJ_AAAJ

[Stefan]

no objections from me.

The revision for the repo root is the same as for the path, but of course works for non-existing paths as well since the root is never deleted.

[Daniel Sahlberg]

Thanks! Committed in r29682

[Daniel Sahlberg]

So. That didn't turn out well at all (https://groups.google.com/g/tortoisesvn/c/IJuG6WvHTds). I've successfully reproduced the error.

Some quick debugging indicate that svn_client_open_ra_session2() now barf if the user doesn't have read access to the repository root. I've reproduced this using VisualSVN Server (it has an "implicit list folder permissions for parents of readable paths" that has to be disabled). I didn't dig all the way down to the server but I'm quite sure the server is returning a 403 on the root but a valid return code on the actual subdirectory.

I'm a bit at loss what to do here since we send the URL when establishing the ra session. If the URL doesn't exist anymore, we get an error. If we send in the root, we get another error. Any ideas?

Kind regards,

Daniel

[Stefan]

would it work if we do both?

            rev = cachedProperties.GetHeadRevision(uuid, path);
            if ((rev == NO_REVISION) || (m_err != nullptr))
            {
                svn_error_clear(m_err);
                rev = cachedProperties.GetHeadRevision(uuid, url);
            }

I don't have a setup ready to test this. At least it would be better than before:

- if the path doesn't exist anymore, we try again with the root

- if root works, fine

- if root doesn't work either, it's no worse than before

Stefan

[Daniel Sahlberg]

Agree with you that it's no worse than before. It seems to work in my testing. I've committed as r29691.

I've also asked on the subversion dev@ mailing list.

Kind regards,

Daniel

[Daniel Sahlberg]

Turned out to be my fault altogether, based in r29499. I've reverted everything and will circle back to the original project monitor issue.