Notifications in system tray

[Mikael Sundberg]

Hi, i missed notifications when i got new tweets so i added it.

I am pretty sure it works in windows/kde/gnome. And although my googling skills tells me it shouldnt work on mac, A friend tells me his program uses the same thing and that works on his mac. so it might work... Anyway, if it doesnt work it simply does nothing instead.
Its simply using java.awt.SystemTray and TrayIcon, so realy nothing complicated.

I attached to images on how it looks on my windows 7

i commited it to my fork on github: http://github.com/bobo/talking-puffin/tree/master


Im still not satisfied, its pretty annoying to have a trayicon without a rightclick meny. and i want to be able to enable/disable, so we will see when i add that.

/Micke

[Dave Briccetti]

Hi Mikael. I haven’t looked at the code yet, but I like the feature.
Can you read this thread, please,
http://groups.google.com/group/talkingpuffin/browse_frm/thread/42994fdcf35f2d40
, specifically the parts about the system tray, and see if there is
anything we need to merge or reconcile?

[Mikael Sundberg]

Yeh, since that code also adds an icon to the systray there is no need for my code to do it also. My code could simply use the icon already added instead. nothing big at all to change

/Micke

2009/8/28 Dave Briccetti <da...@davebsoft.com>

[Dave Briccetti]

Is your change a superset of Don’s? And what about the issue of
multiple tray icons, one for each top frame window? That not being
resolved was part of the reason I deferred integrating Don’s change.
Do you have any thoughts about that?

Thanks again for your contribution.

[Mikael Sundberg]

I add the tray on creation of DesktopUtil, and since thats an object i have a hard to imagine that there would be multiple icons.
I logged in to my account twice (using new from the window) and there still was only one icon.
One backside of my way is that the trayicon does not appear until there is a notification. But should be no problem to fix that. Could for example create it in the topframe as Don did, but put it inside a singleton object


I would say the only common part about mine and Don's changes is that we both used a trayicon. He wanted to minimise down to the tray and he wanted a menu down there (if i understood correctly). I just wanted notifications, if Don's changes would have been in place i would have written 3 LoC less and simply used his icon. The changes complement eachother pretty nice.


I could try to integrate dons changes into my and see where it takes me if that would be wanted?

/Micke

2009/8/28 Dave Briccetti <da...@davebsoft.com>

[Dave Briccetti]

Thanks for the research and explanation.

I think I’ll take your changes “as-is” now, and I’ll study Don’s
changes in the near future.

Will you please create an account in the Jira, so I can attach the
change to you? (Same for anyone else contributing, with your first and
last name).

http://talkingpuffin.org:8080/jira/

[Mikael Sundberg]

ok, ive created an account.

2009/8/28 Dave Briccetti <da...@davebsoft.com>

[Leif J]

TPUF-67 is an issue for suppressing notifications. I have made a pull
request on github.


:-lj

On Aug 28, 8:53 pm, Mikael Sundberg <mikael.sundber...@gmail.com>
wrote: