Evaluating change from Don Brown

[Dave Briccetti]

Hi all. Perhaps some of you can help me evaluate this contribution.

http://github.com/mrdon/talking-puffin/commit/60e863f59936671059adb62a943be8f5ab4b88aa

[mccv]

I think the approach looks fine, although I'm not sure if the quit
handler he implemented conflicts with the mac quite handler I
implemented. I can test that.

However looking at the diffs, it looks like enough imports are
clobbered that it shouldn't even really compile. Am I missing
something there?

On Jul 26, 10:55 am, Dave Briccetti <da...@davebsoft.com> wrote:
> Hi all. Perhaps some of you can help me evaluate this contribution.
>

> http://github.com/mrdon/talking-puffin/commit/60e863f59936671059adb62...

[Dave Briccetti]

Thanks, Mark.

I wonder about adding Quit to the menus on a Mac at all (since there
already is one). And whether a quit is really needed there.

Is the taskbar a Windows-specific thing? Or is that on Linux too?

I’ve invited Don Brown here. Maybe we’ll hear from him.

[mccv]

On a mac we probably shouldn't add it, because as you say it already
exists. We should probably move this stuff to a win or (non-mac)
package... That would solve the problem with double quit handlers
too.

The taskbar may not be windows specific, but it's not universal
either. There were checks in the code for this (Java will tell you if
the system tray is supported), so I don't think this needs to be moved
to an architecture specific place.

[Don Brown]

On Jul 27, 4:51 am, mccv <mark.mcbr...@gmail.com> wrote:
> However looking at the diffs, it looks like enough imports are
> clobbered that it shouldn't even really compile.  Am I missing
> something there?

Yeah, sorry about that. IDEA seems to go a bit nuts with the imports,
and not always (ok, rarely) for the best. Lesson learned: gray'ed
imports don't mean time to reorganize imports.

Don

[Don Brown]

If we do move it out, I'd say non-mac would be best. I developed this
on Linux. I do, however, use mac at work, so I'll test there as well.

The larger issue is how best to have these with multi-session
instances. It will currently add a systray icon per session, which
I'm guessing is not the best idea. Unfortunately, we don't have a
master window to easily attach the lifecycle of the systray to like
something like Pidgeon or Adium has.

Don

[Dave Briccetti]

Don, let me know when you’ve got something new to look at, that
addresses the concerns. Also, did you consider using scala.swing
instead of AWT? Maybe there’s a reason you couldn’t use scala.swing
that I didn’t notice.

Also, it would help me to understand your motivation for making the
changes.

I hope you’ll make more contributions. Work on whatever you like, but
I have prioritized things in Jira best for getting version 1 done.

[Don Brown]

On Tue, Aug 4, 2009 at 6:01 PM, Dave Briccetti<da...@davebsoft.com> wrote:
>
> Don, let me know when you’ve got something new to look at, that
> addresses the concerns. Also, did you consider using scala.swing
> instead of AWT? Maybe there’s a reason you couldn’t use scala.swing
> that I didn’t notice.

The TrayIcon only supports AWT, so scala.swing is out of the question,
unless there is some awt wrapping I'm not aware of.

> Also, it would help me to understand your motivation for making the
> changes.

My motivation was I was tired of puffin taking up task bar space and
wanted it to act more like Pidgin, Twitux (another twitter client), or
most any other chat program.

> I hope you’ll make more contributions. Work on whatever you like, but
> I have prioritized things in Jira best for getting version 1 done.

Yep, no worries. Looking forward to that 1.0 release :)

Don

> >
>

[Dave Briccetti]

Given that the quit would appear on Mac, and the multiple items in the
system tray problem, I’m inclined to let this sit for awhile, or send
it back to you, Don, for a better solution. I would work on it myself,
but there are higher-priority items. I do appreciate your efforts.