DNG disabled by default?

139 views
Skip to first unread message

Matthew Leibowitz

unread,
Mar 16, 2017, 3:18:01 PM3/16/17
to skia-discuss
Hi all you skia fans! I was wondering if there was a reason for the dng/raw codec being excluded in a "default" windows build? I don't think I came across any issues.

skia_use_dng_sdk = 
    !is_fuchsia && !is_win && skia_use_libjpeg_turbo && skia_use_zlib
Also, this appears to be a bit ambiguous since we look to be enabling dng here, but then go on a bit later to add some more requirements (piex):

enabled = skia_use_dng_sdk && skia_use_libjpeg_turbo && skia_use_piex

Leon Scroggins

unread,
Mar 17, 2017, 10:05:12 AM3/17/17
to skia-d...@googlegroups.com
I believe we disabled it on Windows because we were running out of memory on our test Windows bots, due to the large amount of memory used by DNG files.

--
You received this message because you are subscribed to the Google Groups "skia-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to skia-discuss+unsubscribe@googlegroups.com.
To post to this group, send email to skia-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/skia-discuss.
For more options, visit https://groups.google.com/d/optout.



--
Leon Scroggins III

Matthew Leibowitz

unread,
Mar 17, 2017, 1:28:41 PM3/17/17
to skia-discuss
OK, thanks. You may need new test bots :)


On Friday, March 17, 2017 at 4:05:12 PM UTC+2, scroggo wrote:
I believe we disabled it on Windows because we were running out of memory on our test Windows bots, due to the large amount of memory used by DNG files.
On Thu, Mar 16, 2017 at 3:18 PM, Matthew Leibowitz <mattl...@live.com> wrote:
Hi all you skia fans! I was wondering if there was a reason for the dng/raw codec being excluded in a "default" windows build? I don't think I came across any issues.

skia_use_dng_sdk = 
    !is_fuchsia && !is_win && skia_use_libjpeg_turbo && skia_use_zlib
Also, this appears to be a bit ambiguous since we look to be enabling dng here, but then go on a bit later to add some more requirements (piex):

enabled = skia_use_dng_sdk && skia_use_libjpeg_turbo && skia_use_piex

--
You received this message because you are subscribed to the Google Groups "skia-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to skia-discuss...@googlegroups.com.

To post to this group, send email to skia-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/skia-discuss.
For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages