--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsub...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/01b88876-b5ec-4d1a-bb46-b4973000b143%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsubscribe...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/01b88876-b5ec-4d1a-bb46-b4973000b143%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsub...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CANikZL%3DDj7qOFo8eOvfCxzujPmCaPuC7AKpn9AHq3uZXOWExmQ%40mail.gmail.com.
--
Hi Paul,What are you trying to do? Get the same behaviour as the Annotations class? That code is trivial to write, especially for someone of your experience. Don't try and extend it --- ignore it and do something appropriate for your particular testing domain.For a bit of history, the support package started off as a set of examples of how you might want to use WebDriver as a building block for more sophisticated tooling. Naively, I never thought people would actually use the APIs as anything other than inspiration. It's my own fault for not really considering the audience of the code. I think that attitude started to change with the Wait class in 2009 once I understood what was happening, but PageFactory dates to 2007. If you'd like to refactor the heck out of and keep the public-facing APIs pin-compatible, go for it.Simon
On Sat, Mar 4, 2017 at 10:25 AM, Paul Hammant <pa...@hammant.org> wrote:
I'm maintaining locators in Java for Angular in the ngWebDriver project (yes yes, it's just a wrapper for Protractor from the Angular team).I'm wanting to make new page-object style annotations for it. NgWebDriver like Protractor is going to the client via the JavascriptExecutor and interoperating with the inner workings of Angular in order to do things. That manifests itself as another series of things like By.id(..). Those would be ByAngular.model(..), ByAngular.repeater(..) and more.The annotation @FindBy is fixed. Sure, I'd want a new @AngularFindBy. So, looking at Annotations.buildBy(..) I don't think it is open for alternates.I'm pretty sure there is a backwards-compatible way of changing WebDriver to allow for new @FindBy inspired annotations via parent annotations:public @interface FindBy extends PageObjectAnnotation {...}The logic in Annotations.buildBy(..) would change to looking PageObjectAnnotation and calling methods within that.Thoughts?- Paul
--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsubscribe...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/01b88876-b5ec-4d1a-bb46-b4973000b143%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsub...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAOrAhYF%3Dp22jwhwhbVa91XsyQTLz4Frfpcu7_PA5wcCpRiie-A%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAOrAhYF%3Dp22jwhwhbVa91XsyQTLz4Frfpcu7_PA5wcCpRiie-A%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsub...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CA%2B298UiY012M3ojfMFXbbrwKbu4A8C45AJH8nDY6iBKZq%3D%3DfXQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsub...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/27c9478d-170e-4fda-ad18-df131fed07cf%40googlegroups.com.