[PSR-13] Fix for breaking bug

[Larry Garfield]

Michael Babker on Twitter recently alerted me to a bug in the new PSR-13 release. Specifically, it typed withAttribute(string $name, string $value), which is what the docblock had, but the spec said more than just strings were allowed for $value. In particular, arrays and bool are called out specifically. This is an API break.

After discussing with implementers (mainly Symfony) to verify existing behavior, I offer this second errata with fixes to the spec.

https://github.com/php-fig/fig-standards/pull/1222

The PR there includes links to the package updates.

As an errata this would require another Core Committee vote, which I will call in two weeks unless there are any objections before then, or if enough of the CC says to just go ahead and vote sooner. (The two week discussion period is encouraged but not strictly required, so I'm willing to save time if everyone else is.)

Also, please check and make sure there were no other issues introduced that we missed. I'd hate to have to have another bug fix release. :-(

--
Larry Garfield
la...@garfieldtech.com

[Larry Garfield]

Core Committee members, any feedback here? Good, bad, or otherwise?

--Larry Garfield

[Enrico Zimuel]

Hi Larry,

I did a review of the PR and it looks good.

+1 for me.

Regards,

Enrico Zimuel

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/a6824371-d0be-4ea5-8da2-7c1af4bc9c12%40www.fastmail.com.

[Ben Edmunds]

+1

[Matthew Weier O'Phinney]

No additional feedback from me; I'm good with the proposed changes. 

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/6b6e6605-58df-4d5f-988c-bec7c04ed67c%40www.fastmail.com.

[Woody Gilk]

I’m good with these changes, though I wish the type was more strict. 

Sent from my iPhone

On Feb 22, 2021, at 4:50 PM, Matthew Weier O'Phinney <mweiero...@gmail.com> wrote:



To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAJp_myVKtdrMWeOpv9gNCTPa4-2YWce79cp-hTgznC%2BgkRU4Yg%40mail.gmail.com.

[Larry Garfield]

On Tue, Feb 23, 2021, at 9:15 AM, Woody Gilk wrote:
> I’m good with these changes, though I wish the type was more strict.

I'm always for tighter typing where possible, but in this situation I don't think it could be stricter. int and float are both needed. String is needed. The spec text explicitly says that Stringable is allowed, and that arrays are allowed and have a particular meaning. We kinda need all of them.

--Larry Garfield