completes -> getCompletes

[Nomi Harris]

Today I tried to compile obo-edit and was surprised that it had the same problem that I fixed in Phenote the other day--obo-edit won't compile with the latest obo because org.obo.datamodel.OBORestriction.completes was changed to getCompletes, but this change was not made in several obo-edit classes that still call completes:

   [javac] /Users/nomi/workspace/OBO-Edit/src/org/oboedit/gui/OBOCellRenderer.java:303: cannot find symbol

    [javac] symbol  : method completes()

    [javac] location: interface org.obo.datamodel.OBORestriction

    [javac]                             if (tr.completes()) {

    [javac]                                   ^

    [javac] /Users/nomi/workspace/OBO-Edit/src/org/oboedit/gui/actions/CloneAction.java:100: cannot find symbol

    [javac] symbol  : method completes()

    [javac] location: interface org.obo.datamodel.OBORestriction

    [javac]                                             if(((OBORestriction) parentLink).completes())

    [javac]                                                                             ^

    [javac] /Users/nomi/workspace/OBO-Edit/src/org/oboedit/gui/actions/SpecificCompletesAction.java:81: cannot find symbol

    [javac] symbol  : method completes()

    [javac] location: interface org.obo.datamodel.OBORestriction

    [javac]                     if (tr.completes() != changeTo) {

    [javac]                           ^

    [javac] /Users/nomi/workspace/OBO-Edit/src/org/oboedit/gui/components/CompleteDefPanel.java:411: cannot find symbol

    [javac] symbol  : method completes()

    [javac] location: interface org.obo.datamodel.OBORestriction

    [javac]                     if (!link.completes())

    [javac]                              ^

    [javac] /Users/nomi/workspace/OBO-Edit/src/org/oboedit/gui/components/CrossProductEditorComponent.java:560: cannot find symbol

    [javac] symbol  : method completes()

    [javac] location: interface org.obo.datamodel.OBORestriction

    [javac]                     if (!link.completes())

    [javac]                              ^

    [javac] /Users/nomi/workspace/OBO-Edit/src/org/oboedit/gui/widget/IntersectionPanel.java:702: cannot find symbol

    [javac] symbol  : method completes()

    [javac] location: interface org.obo.datamodel.OBORestriction

    [javac]                     if (!link.completes())

    [javac]                              ^

    [javac] Note: Some input files use or override a deprecated API.

On Sep 14, 2010, at 10:48 AM, Nomi Harris wrote:

Thanks for the error report and fix (your fix was correct).  I hadn't noticed this right away because I hadn't updated my obo repository.  A change was made in org.obo.datamodel.OBORestriction (the "completes" method was renamed "getCompletes") that prevented Phenote from compiling.

I committed the fixes to the Phenote classes you mentioned below.

Nomi

On Sep 7, 2010, at 5:01 PM, pre...@science.oregonstate.edu wrote:

Nomi,

While I was performance-tuning my local build of Phenote, I noticed a pre-existing build error and made an educated guess as to the correction. It cleared up the err, but I'm not sure about the best way to more fully test the change, so I though I would just give you a heads up and you can do what you want with the info. 

The err concerned a missing method in the OBORestriction interface: completes(). There is a getCompletes() in that class, so I changed it and it builds fine. No idea as to whether that was the appropriate change.

Files changed:

phenote/src/java/phenote/datamodel/OboUtil.java phenote/src/java/phenote/gui/TermInfo2.java phenote/src/java/phenote/gui/field/PostCompGui.java phenote/src/java/phenote/util/HtmlUtil.java
svn link to an example of the change: http://palea.cgrb.oregonstate.edu/viewsvn/phenote/phenote/src/java/phenote/datamodel/OboUtil.java?r1=4&r2=3&pathrev=4 Cheers, Justin Preece

[Amina Abdulla]

My mistake - I haven't checked in those changes. I'll do it right away.
Thanks,
Amina

--
You received this message because you are subscribed to the Google Groups "OBO-Edit Developers Group" group.
To post to this group, send email to obo-ed...@googlegroups.com.
To unsubscribe from this group, send email to obo-edit-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/obo-edit-dev?hl=en.

[Amina Abdulla]

OBO-Edit and associated jars should be up-to-date now.

Thanks,
Amina

On 9/17/10 10:33 AM, Nomi Harris wrote: