Issue 120 in maven-alfresco-archetypes: Enforcer Alfresco version checking rule seems wrong

[maven-alfres...@googlecode.com]

Status: New
Owner: bwav...@ziaconsulting.com
Labels: Type-Defect Priority-Medium

New issue 120 by bwav...@ziaconsulting.com: Enforcer Alfresco version
checking rule seems wrong
http://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=120

Details here:
https://groups.google.com/d/msg/maven-alfresco/HvRbHkG7QLI/-Hvgm6MhZtAJ

I propose we use the following regex:
<regex>^([4\.(1\.[1-9][0-9]*(\.[1-9][0-9]*)?|2\.[a-z]))$</regex>

This is pretty permissive with respect to the Enterprise 4.1 version series
and the community 4.2 series but blocks back versions that are not
supported by this infrastructure. It also blocks enterprise not in the
4.1.x space and community not in the 4.2.x space.

I'm happy to make this change if folks agree or if folks want to optimize
the regex in a different fashion, let me know and I can propose some
additional expressions.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[maven-alfres...@googlecode.com]

Comment #1 on issue 120 by samuel.l...@alfresco.com: Enforcer Alfresco

version checking rule seems wrong
http://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=120

Sorry for the delay...

The goal of the enforcer regexp was to provide a nice (?) error message
when using a version of Alfresco where the POM files were empty, which is
4.1.1 or before.
It therefore matches
* 4.1.2 and above
* 4.2 and above
* 5 and above

The current regexp does exactly that ([5-9] matches the first number, not
the middle one) and I don't see what the problem is with it.
We don't want to match the end of the version string, because there are
hotfix versions which have 4 digits, and matching that too would make it
unnecessarily complex.

Could you explain what you are trying to fix?

[maven-alfres...@googlecode.com]

Comment #2 on issue 120 by bwav...@ziaconsulting.com: Enforcer Alfresco

version checking rule seems wrong
http://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=120

I was working against an earlier version of the parent pom that had the
following:

<regex>^(4\.[2-9]|[5-9]).*</regex>

Which I had to override for enterprise... The new regex seems fine to me :)

[maven-alfres...@googlecode.com]

Updates:
Status: Started
Labels: Milestone-Release-sdk-1.0.2

Comment #3 on issue 120 by colum...@gmail.com: Enforcer Alfresco version

checking rule seems wrong
http://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=120

Can this one be closed?

[maven-alfres...@googlecode.com]

Comment #4 on issue 120 by bwav...@ziaconsulting.com: Enforcer Alfresco

version checking rule seems wrong
http://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=120

Seems like it can :) Is that something you are comfortable with me doing? I
didn't want to presume.

[maven-alfres...@googlecode.com]

Updates:
Status: Verified

Comment #5 on issue 120 by maurizio...@alfresco.com: Enforcer Alfresco

version checking rule seems wrong
http://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=120

Issue verified. Thanks!