enforcer version rule still seems wrong

10 views
Skip to first unread message

Bindu Wavell

unread,
May 5, 2013, 6:47:35 PM5/5/13
to maven-a...@googlegroups.com
Here is what's in the current 1.0 release of the parent pom:

    <regex>^(4\.[2-9]|[5-9]).*</regex>

I just discovered the 1.1 version of the parent pom includes a better regex:

    <regex>^(4\.1\.[2-9]|4\.[2-9]|[5-9]).*</regex>

It's unclear why we would want the middle number to be [2-9] or [5-9]... Or why we don't care what matches at the end: .*

I propose:

    <regex>^(4\.(1\.[1-4](\.[0-9]*)?|2\.[a-c]))$</regex>

Or something more permissive such as:

    <regex>^(4\.(1\.[1-9][0-9]*(\.[1-9][0-9]*)?|2\.[a-z]))$</regex>



Gabriele Columbro

unread,
May 6, 2013, 4:32:44 AM5/6/13
to maven-a...@googlegroups.com
Bindu, 

yes you are correct, version 1.0 was not supported with Enterprise so we enforced only that 4.2+ (Community) could work with it.

With the version 1.0.1 we added support for Enterprise (4.1.2 +).

Moving forward all future Alfresco versions should be compatible, so probably we can freeze the enforcer rule.

Samuel, what do you think about Bindu observations? Can you guys sort out the best and less risky regexp? 

Thanks,
-- 
Gabriele Columbro
Principal Architect, 
Consulting Services




--
You received this message because you are subscribed to the Google Groups "Maven Alfresco Lifecycle Discussion Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to maven-alfresc...@googlegroups.com.
To post to this group, send email to maven-a...@googlegroups.com.
Visit this group at http://groups.google.com/group/maven-alfresco?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply all
Reply to author
Forward
0 new messages