Solution for enabling ssh._extra args
54 views
Skip to first unread message
Taylor Dean
Nov 6, 2019, 1:48:50 PM11/6/19
to lsyncd
lsyncd currently ignores the ssh._extra args parameter. I have posted a pull request to the repo that fixes this problem. Link to the pull request is here: https://github.com/axkibe/lsyncd/pull/583
Axel Kittenberger
Nov 6, 2019, 2:53:58 PM11/6/19
to lsyncd
Thanks,
The reasoning is, I see in the issue reports people putting stuff into it they really shouldn't. I wrote in the documentation, the _extra parameter is ment as workaround for people knowing what they're doing. However, I think, people that know what they do can simply overload the necessary functions thus making it "a patch".
the thing is tough, I'd rather take the _extra parameter all away together (Lsyncd 3.0 in preparation, albeit I admit that project got a little stalled) will not have an _extra parameter.
The reasoning is, I see in the issue reports people putting stuff into it they really shouldn't. I wrote in the documentation, the _extra parameter is ment as workaround for people knowing what they're doing. However, I think, people that know what they do can simply overload the necessary functions thus making it "a patch".
If you're missing specific ssh parameters, I'll welcome patches for those.
Kind regards, Axel
On Wed, Nov 6, 2019 at 7:48 PM Taylor Dean <tay...@makeshift.dev> wrote:
lsyncd currently ignores the ssh._extra args parameter. I have posted a pull request to the repo that fixes this problem. Link to the pull request is here: https://github.com/axkibe/lsyncd/pull/583
--
You received this message because you are subscribed to the Google Groups "lsyncd" group.
To unsubscribe from this group and stop receiving emails from it, send an email to lsyncd+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/lsyncd/3eed7712-aa79-436b-9e97-a858a5311a34%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages