Reason this enhancement is critical for this milestone: Graduating a bugfix KEP to ensure it can reach users as quickly as possible, as kubelet bug fixes take many releases to graduate due to version skew support
Risks from adding code late: Low. Actual code changes between the two PRs are about ~6 lines, plus unit test updates. There is only one semantic change (additional validation), and everything else is limited to feature flags and unit tests. No e2e updates.
Risks from cutting enhancement: We have partially implemented fixes to prevent users from setting the termination grace period to a negative value, but it has not yet fully landed (see 2nd half in #103245). We found some final small issues in API review today (07/08) on both PRs that need to be resolved before merge. The main risk is that this feature already isn't slated to fully graduate until 1.25, and is currently slated to remain off by default until 1.24 to avoid version skew issues; an additional release delay pushes this to 1.26.
Savitha Raghunathan
unread,
Jul 12, 2021, 9:26:37 PM7/12/21
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Elana Hashman, releas...@kubernetes.io, kubernetes-sig-release, kubernete...@googlegroups.com
Hi Elana,
Thanks for creating this exception request. After following the discussion here, we are APPROVING this request.
Please make sure to merge the completed PRs by July 14th, EOD Pacific time. If you have any questions, please feel free to reach out to us in
the #sig-release slack channel.
Have a great day!
Regards,
Savitha,
1.22 Release Team Lead
--
To unsubscribe from this group and stop receiving emails from it, send an email to release-team...@kubernetes.io.
Elana Hashman
unread,
Jul 13, 2021, 3:28:56 PM7/13/21
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Savitha Raghunathan, releas...@kubernetes.io, kubernetes-sig-release, kubernete...@googlegroups.com
Thank you Savitha!
The first PR is merged and the next should be merged by EOD!