Bug flipping Animation sprites

[Rob Terrell]

I found a bug in the Animation class -- if you use either of the flip properties, the only frame that gets flipped is the current frame. When the animation proceeds to the next frame, it is not flipped. 

The link for contribution guidelines (https://github.com/excaliburjs/Excalibur/blob/master/CONTRIBUTING.md) is 404 so I'm not sure what branch I should be using, but I've made a fix on master and can create a pull request. 

-- Rob

[Erik Onarheim]

Hi Rob,

Definitely a bug, can you open an issue for us with a repro? 

https://github.com/excaliburjs/Excalibur/issues

Thanks,
Erik

--
You received this message because you are subscribed to the Google Groups "excaliburjs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to excaliburjs...@googlegroups.com.
To post to this group, send email to excal...@googlegroups.com.
Visit this group at https://groups.google.com/group/excaliburjs.
To view this discussion on the web visit https://groups.google.com/d/msgid/excaliburjs/9f5d239b-2781-4fe2-99eb-ab449fd0dd08%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Josh]

Sorry about that! The correct link for the contributing guidelines is https://github.com/excaliburjs/Excalibur/blob/master/.github/CONTRIBUTING.md

We have a Github template that should auto-populate when you open an issue. It will help you submit a bug report.

As far as submitting a fix is concerned, I'd recommend taking a look at https://github.com/excaliburjs/Excalibur/blob/master/.github/CONTRIBUTING.md#submitting-changes

Thanks for your help!

On Mon, Sep 18, 2017 at 3:58 PM, Erik Onarheim <erik.o...@gmail.com> wrote:

Hi Rob,

Definitely a bug, can you open an issue for us with a repro? 

https://github.com/excaliburjs/Excalibur/issues

Thanks,
Erik

On Mon, Sep 18, 2017 at 3:34 PM Rob Terrell <rter...@zynga.com> wrote:

I found a bug in the Animation class -- if you use either of the flip properties, the only frame that gets flipped is the current frame. When the animation proceeds to the next frame, it is not flipped. 

The link for contribution guidelines (https://github.com/excaliburjs/Excalibur/blob/master/CONTRIBUTING.md) is 404 so I'm not sure what branch I should be using, but I've made a fix on master and can create a pull request. 

-- Rob

--
You received this message because you are subscribed to the Google Groups "excaliburjs" group.

To unsubscribe from this group and stop receiving emails from it, send an email to excaliburjs+unsubscribe@googlegroups.com.

To post to this group, send email to excal...@googlegroups.com.
Visit this group at https://groups.google.com/group/excaliburjs.
To view this discussion on the web visit https://groups.google.com/d/msgid/excaliburjs/9f5d239b-2781-4fe2-99eb-ab449fd0dd08%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "excaliburjs" group.

To unsubscribe from this group and stop receiving emails from it, send an email to excaliburjs+unsubscribe@googlegroups.com.

To post to this group, send email to excal...@googlegroups.com.
Visit this group at https://groups.google.com/group/excaliburjs.

To view this discussion on the web visit https://groups.google.com/d/msgid/excaliburjs/CAMroXacWTCVp_YKL7D1CLdUWqSHV5MdX_Nn6BL9OAVpbAL9B%2BA%40mail.gmail.com.

[Erik Onarheim]

Hi Rob, 

I can't seem to reproduce this locally with this codepen using the latest release of excalibur (v0.12)

https://codepen.io/anon/pen/vegpKj?editors=0010#0

Can you provide more details?

Thanks,
Erik