Error running `npm run all` (Mac OSX)

[Robert O'Shea]

Hi all,

Contributed to this project before but had to take a break from it. Now that I'm back `npm run all` fails with an error:

This is my first time coming across this error. I have recloned the proejct and still the same error. I have run `npm install` so that isn't the problem. Could I need a newer version of Node?

Any other information required can be given.

[Kamran Ayub]

I can almost guarantee it's font rendering issues with the image diff tests. Can you list the tests that are failing? We may split them out so we ignore them on local builds... if they are image diff failures, you can ignore them.

--
You received this message because you are subscribed to the Google Groups "excaliburjs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to excaliburjs...@googlegroups.com.
To post to this group, send email to excal...@googlegroups.com.
Visit this group at https://groups.google.com/group/excaliburjs.
To view this discussion on the web visit https://groups.google.com/d/msgid/excaliburjs/608546b1-fce3-4edf-9145-8ab874d79c08%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Robert O'Shea]

It seems to be most of the Label tests are failing, along with a few in TileMap

[Erik Onarheim]

I think this is the image diff tests on label... the number of failing tests seems familiar.

Can you show me the output of the failing TileMap test?

@karman We should split the image diff tests as an "optional" test suite since different platforms render fonts and images differently and it will be very painful to maintain this list (even different flavors of windows render things differently)

@robert Go ahead and comment out these failing tests for now, if you feel ambitious you could look into the option test suite idea for visual tests

[Robert O'Shea]

Here is the TileMap tests.

@Erick I guess I can take a look at that feature. So to be clear, Exalicbur is using a screenshot of the visual test then uses diff (or related tool) to test against the expected output? So I'd be making this an optional feature?

[Erik Onarheim]

Ah those tilemap are warnings for empty specs not actually failing (our bad on those) but they should fail the build.

Image diff is done by running the visual tests in PhantomJS and grabbing the images from the canvas and doing a pixel by pixel comparison with a really janky custom jasmine matcher. Again only if you're ambitious :) I'd maybe just comment out the tests if you want to work on something else. What I have in mind is 2 test suites, non-visual standard unit tests, and the less deterministic and more brittle visual test suite which would include the label tests and any other tests using that image diff matcher.

[Erik Onarheim]

I have a somewhat related issue that I just opened https://github.com/excaliburjs/Excalibur/issues/833 I feel like this 2 test suite idea may fall under that

[Erik Onarheim]

Meant to say the empty specs "should not fail the build" so you can safely ignore the TileMap specs

To view this discussion on the web visit https://groups.google.com/d/msgid/excaliburjs/d1cac35b-98d6-48b4-9b10-561663cba10a%40googlegroups.com.

[Robert O'Shea]

I'll finish off my work on the Button feature, then I'll take a look