Re: [Django] #33616: Supporting robust on

Django

unread,

Apr 4, 2022, 12:16:20 AM4/4/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Josh, Would you like to prepare a patch?

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Apr 4, 2022, 12:28:36 AM4/4/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Josh Smeaton):

I haven't got the time to put a patch together *right now* but I could do
so in the near future. Consider tagging this as "easy pickings" for a
budding contributor?

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:4>

Django

unread,

Apr 4, 2022, 12:46:25 AM4/4/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Josh Smeaton):

* easy: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:5>

Django

unread,

Apr 4, 2022, 12:51:40 AM4/4/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Josh Smeaton):

I've started an easy pickings thread on -developers ML and would be happy
to review and guide someone to make the change:
https://groups.google.com/g/django-developers/c/Hyqd1Rz6cFs

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:6>

Django

unread,

Apr 4, 2022, 11:26:50 AM4/4/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam Johnson):

Good feature suggestion. The execution in captureOnCommitCallbacks would
need extending too :)

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:7>

Django

unread,

Apr 13, 2022, 10:09:03 AM4/13/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------

Reporter: Josh Smeaton | Owner: Dulalet
Type: New feature | Status: assigned

Changes (by Dulalet):

* owner: nobody => Dulalet
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:8>

Django

unread,

Apr 15, 2022, 12:12:44 AM4/15/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: Dulalet
Type: New feature | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_docs: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1

Comment:

[https://github.com/django/django/pull/15602 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:9>

Django

unread,

May 8, 2022, 9:49:16 PM5/8/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: Dulalet
Type: New feature | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Shivan Sivakumaran):

Can this ticket be closed? Seems like the PR was accepted.

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:10>

Django

unread,

May 8, 2022, 10:26:12 PM5/8/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: Dulalet
Type: New feature | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Josh Smeaton):

Replying to [comment:10 Shivan Sivakumaran]:

> Can this ticket be closed? Seems like the PR was accepted.

Not until the PR is merged, then it'll be closed as fixed

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:11>

Django

unread,

Jun 12, 2022, 5:20:51 AM6/12/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: Dulalet
Type: New feature | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Wobrock):

* cc: David Wobrock (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:12>

Django

unread,

Jun 14, 2022, 1:57:45 PM6/14/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------

Reporter: Josh Smeaton | Owner: Abhinav
| Yadav

Changes (by Abhinav Yadav):

* owner: Dulalet => Abhinav Yadav

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:13>

Django

unread,

Jun 14, 2022, 6:42:04 PM6/14/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: Abhinav
| Yadav
Type: New feature | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sarah Abderemane):

[https://github.com/django/django/pull/15766 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:14>

Django

unread,

Jun 22, 2022, 2:33:50 PM6/22/22

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Abhinav Yadav):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:15>

Django

unread,

Jun 24, 2022, 11:39:38 AM6/24/22

to django-...@googlegroups.com

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Wobrock):

* needs_better_patch: 0 => 1

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:16>

Django

unread,

Jun 28, 2022, 6:35:38 AM6/28/22

to django-...@googlegroups.com

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by David Wobrock):

* needs_better_patch: 1 => 0

* needs_tests: 1 => 0

* needs_docs: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:17>

Django

unread,

Jun 29, 2022, 12:10:45 AM6/29/22

to django-...@googlegroups.com

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:18>

Django

unread,

Sep 6, 2022, 6:05:36 AM9/6/22

to django-...@googlegroups.com

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0

* needs_tests: 1 => 0

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:19>

Django

unread,

Sep 6, 2022, 7:23:36 AM9/6/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: Abhinav
| Yadav

Type: New feature | Status: closed

Component: Database layer | Version: 4.0
(models, ORM) |

Severity: Normal | Resolution: fixed

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"4a1150b41d1312feacd4316b2691227f5a509ae9" 4a1150b4]:
{{{
#!CommitTicketReference repository=""
revision="4a1150b41d1312feacd4316b2691227f5a509ae9"
Fixed #33616 -- Allowed registering callbacks that can fail in
transaction.on_commit().

Thanks David Wobrock and Mariusz Felisiak for reviews.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:20>

Django

unread,

Sep 6, 2022, 3:39:55 PM9/6/22

to django-...@googlegroups.com

#33616: Supporting robust on_commit handlers.
-------------------------------------+-------------------------------------
Reporter: Josh Smeaton | Owner: Abhinav
| Yadav
Type: New feature | Status: closed
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"3a084831e266bc9a4e3bc1ba89e44ffb7cf35a9c" 3a08483]:
{{{
#!CommitTicketReference repository=""
revision="3a084831e266bc9a4e3bc1ba89e44ffb7cf35a9c"
Refs #33616 -- Updated BaseDatabaseWrapper.run_on_commit comment.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33616#comment:21>

Reply all

Reply to author

Forward

Re: [Django] #33616: Supporting robust on_commit handlers.

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django