Current mustanglibrary master branch tests are failing

[Richard Smith]

Hi,

I have just forked the mustang library master branch (commit 56b9099c3c42efb337cd65623c5187ca93f04e6e) , and locally built using  mvn clean package.(MacOS 26.3.1, Macbook M1 Pro, openjdk version "21.0.9" 2025-10-21 LTS)

The build reports two failing tests:

[INFO] Running org.mustangproject.ZUGFeRD.ZF2Test
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 s -- in org.mustangproject.ZUGFeRD.ZF2Test
[INFO] Running org.mustangproject.ZUGFeRD.ZF2ZInvoiceImporterTest
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.424 s -- in org.mustangproject.ZUGFeRD.ZF2ZInvoiceImporterTest
[INFO] Running org.mustangproject.ZUGFeRD.UBLTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.030 s -- in org.mustangproject.ZUGFeRD.UBLTest
[INFO] Running org.mustangproject.ZUGFeRD.ZF2ZInvoiceImporterTest
[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.171 s -- in org.mustangproject.ZUGFeRD.ZF2ZInvoiceImporterTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   UBLTest.testEdgeInvoiceImportUBL2:134 » Arithmetic Payable total in XML is 14918.84, but calculated total is 4918.84 with tax basis 12536.84 and with positions 12536.84 = 818.04 + 11718.80
[ERROR]   ZF2PushTest.testPushExport:106 » Arithmetic Payable total in XML is 571.04, but calculated total is 572.04 with tax basis 496.00 and with positions 496.00 = 160.00 + 316.00 + 20.00
[INFO]
[ERROR] Tests run: 147, Failures: 0, Errors: 2, Skipped: 0
[INFO]

[jochen...@gmail.com]

Hello,

Yes, feel free to fix if you can or switch to a release branch if you want it to run without errors.

Kind regards

Jochen

[Richard Smith]

Hi thanks for your reply.

I wanted to contribute a PR (which I have now submitted). Should I have branched from the most recent release branch instead ?  

By the way - did you know that as a maintainer, it is quite easy to set up a Github Action that reports the state of a branch's last executed build & test as a "Testing" badge ?  Might be useful for you to make the test status more visible.    

https://docs.github.com/en/actions/how-tos/monitor-workflows/add-a-status-badge

Regards,

Richard

--
You received this message because you are subscribed to a topic in the Google Groups "ZUGFeRD" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/zugferd/CRdwJM8hnT4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to zugferd+u...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/zugferd/836b2ca6-520d-46a9-b9d4-fc3b9875fd8fn%40googlegroups.com.