Patch 7.4.901

Bram Moolenaar

unread,

Oct 30, 2015, 9:24:03 AM10/30/15

to vim...@googlegroups.com

Patch 7.4.901
Problem: When a BufLeave autocommand changes folding in a way it syncs
undo, undo can be corrupted.
Solution: Prevent undo sync. (Jacob Niehus)
Files: src/popupmnu.c

*** ../vim-7.4.900/src/popupmnu.c 2014-07-23 21:10:39.867766788 +0200
--- src/popupmnu.c 2015-10-30 14:19:21.681104047 +0100
***************
*** 568,574 ****
--- 568,578 ----
if (p_pvh > 0 && p_pvh < g_do_tagpreview)
g_do_tagpreview = p_pvh;
++RedrawingDisabled;
+ /* Prevent undo sync here, if an autocommand syncs undo weird
+ * things can happen to the undo tree. */
+ ++no_u_sync;
resized = prepare_tagpreview(FALSE);
+ --no_u_sync;
--RedrawingDisabled;
g_do_tagpreview = 0;

***************
*** 659,665 ****
--- 663,671 ----
* redraw. */
if (resized)
{
+ ++no_u_sync;
win_enter(curwin_save, TRUE);
+ --no_u_sync;
update_topline();
}

***************
*** 670,676 ****
--- 676,686 ----
pum_do_redraw = FALSE;

if (!resized && win_valid(curwin_save))
+ {
+ ++no_u_sync;
win_enter(curwin_save, TRUE);
+ --no_u_sync;
+ }

/* May need to update the screen again when there are
* autocommands involved. */
*** ../vim-7.4.900/src/version.c 2015-10-25 22:41:56.703017233 +0100
--- src/version.c 2015-10-30 14:16:43.274962288 +0100
***************
*** 743,744 ****
--- 743,746 ----
{ /* Add new patch number below this line */
+ /**/
+ 901,
/**/

--
Creating the world with Emacs: M-x let-there-be-light
Creating the world with Vim: :make world

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Ajit Thakkar

unread,

Oct 31, 2015, 3:42:40 PM10/31/15

to vim_dev

On Friday, October 30, 2015 at 10:24:03 AM UTC-3, Bram Moolenaar wrote:
> Patch 7.4.901

Missing patch 901 on the mercurial mirror?

Christian Brabandt

unread,

Oct 31, 2015, 4:08:26 PM10/31/15

to vim_dev

Hi Ajit!

https://bitbucket.org/vim-mirror/vim/commits/ce8b286e89efffae829f71340d8518ff1d268ba3

As far as I can see, all commits look like they are available. Anyting
missing?

Best,
Christian
--
Gewisse Bücher scheinen geschrieben zu sein, nicht damit man
daraus lerne, sondern damit man wisse, dass der Verfasser etwas
gewusst hat.
-- Goethe, Maximen und Reflektionen, Nr. 218

Ajit Thakkar

unread,

Oct 31, 2015, 4:11:37 PM10/31/15

to vim_dev

I did not see a commit notice for 901 on the right-hand "recent activity" side bar. I didn't check further. Are the activity notices decoupled from actual commits?

--
Ajit Thakkar, PhD, FCIC

Professor Emeritus

Chemistry Department
University of New Brunswick
Fredericton, NB, Canada
http://www2.unb.ca/~ajit/

Editor, Computational & Theoretical Chemistry
http://www.journals.elsevier.com/computational-and-theoretical-chemistry/#description

Have you seen my concise text book, Quantum Chemistry?

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to a topic in the Google Groups "vim_dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/vim_dev/rEOb16I3KkQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to vim_dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Christian Brabandt

unread,

Oct 31, 2015, 4:17:54 PM10/31/15

to vim_dev

Hi Ajit!

On Sa, 31 Okt 2015, Ajit Thakkar wrote:

> I did not see a commit notice for 901 on the right-hand "recent activity"
> side bar. I didn't check further. Are the activity notices decoupled from
> actual commits?

Hm strange, that it does not show up there. I can't tell why. But if you
click on the rss feed, it does show up.

Best,
Christian
--
Ernste Menschen haben selten Ideen. Ideenreiche sind nie ernst.
-- Paul Ambroise Valéry

Ajit Thakkar

unread,

Oct 31, 2015, 4:26:42 PM10/31/15

to vim_dev

Thanks, Christian.

It is there!

--
Ajit Thakkar, PhD, FCIC

Professor Emeritus

Chemistry Department
University of New Brunswick
Fredericton, NB, Canada
http://www2.unb.ca/~ajit/

Editor, Computational & Theoretical Chemistry
http://www.journals.elsevier.com/computational-and-theoretical-chemistry/#description

Have you seen my concise text book, Quantum Chemistry?

Reply all

Reply to author

Forward