Fwd: Vim Java Syntax Patch

[Sam Lijin]

Hi vim-dev,

First-time contributor here! I've got two patches for what I believe to be two separate issues in Java syntax highlighting.

I tried pinging Claudio, who's listed as the maintainer for them, but he hasn't responded to either of my emails, so per contributing.md I'm opening this up to the list.

Thanks,

Sam

---------- Forwarded message ---------
From: Sam Lijin <sxl...@google.com>
Date: Wed, Jan 3, 2018 at 4:31 PM
Subject: Vim Java Syntax Patch
To: <cla...@fleiner.com>

Hi Claudio,

I recently fixed - what I believe to be - two issues with Vim's native Java syntax highlighting rules.

The first is that the javaAnnotation syntax group improperly includes, by virtue of wildcard regex matches, all arguments provided to a Java annotation, which can cause weird issues like a javaParenError (if one of the annotation arguments is a string which contains a closing parenthesis).

The second is that the javaDocTags syntax region improperly includes javaCommentStar, which results in inline Javadoc tags highlighting any leading asterisks as part of the tag, rather than as a Java comment delimiter.

Attached please find two patches which, I believe, are appropriate fixes for these issues.

Please let me know if you agree or not.

Thanks,

Sam

[Sam Lijin]

Bump. I'd appreciate if someone could take a look at this.

Sam

[Bram Moolenaar]

Sam Lijin wrote:

> Bump. I'd appreciate if someone could take a look at this.
>
> Sam
>
>
> On Tue, Jan 16, 2018 at 11:44 AM Sam Lijin <sxl...@google.com> wrote:
>
> > Hi vim-dev,
> >
> > First-time contributor here! I've got two patches for what I believe to be
> > two separate issues in Java syntax highlighting.
> >
> > I tried pinging Claudio, who's listed as the maintainer for them, but he
> > hasn't responded to either of my emails, so per contributing.md I'm
> > opening this up to the list.

I haven't heard from Claudio for a few years. It would be good if
someone else can take over maintenance.


--
You can tune a file system, but you can't tuna fish
-- man tunefs

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Sam Lijin]

Oops, missed this email.

Bram: is there any chance you could also review the Java syntax patches?

I'd volunteer to do it, but I've been busy with personal stuff lately and haven't been able to make guarantees about responsiveness for open source stuff.

[David Barnett]

Any chance we could get Dan Sharp (the maintainer for ftplugin/java.vim) to take it over? Bram, do you review these sometimes when the maintainer is unreachable, or is it strictly blocked on finding a working maintainer?

David

[David Barnett]

+Dan

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to a topic in the Google Groups "vim_dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/vim_dev/ZYq7prP1m-c/unsubscribe.
To unsubscribe from this group and all its topics, send an email to vim_dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Bram Moolenaar]

I haven't heard from Dan Sharp for a few years, so that's not an
alternative.

I already have too much work to do. I can include simple patches that
are an obvious improvement, but we really should have a maintainer for
the Java files.

--
TALL KNIGHT: We are now no longer the Knights Who Say Ni!
ONE KNIGHT: Ni!
OTHERS: Sh!
ONE KNIGHT: (whispers) Sorry.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD