[vim/vim] ftplugin/python.vim: improve matching for ]] [[ ]m [m (#842)

[James Sully]

This should stop ]], [[, ]m, and [m from jumping to identifiers beginning with either "def" or "class".

For instance, as it is currently, if your cursor is on apply, below:

def apply(f, x):
    return f(x)

default = "foo"
classy_identifier="bar"

def show_default():
    print(default)

Then you'll have to do ]m 3 times in order to land on def show_default(), instead of once.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/842

Commit Summary

• ftplugin/python.vim: improve matching for ]] [[ ]m [m

File Changes

• M runtime/ftplugin/python.vim (10)

Patch Links:

• https://github.com/vim/vim/pull/842.patch
• https://github.com/vim/vim/pull/842.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[Coveralls]

Coverage decreased (-0.02%) to 62.28% when pulling fcae53e on sullyj3:master into 18dfb44 on vim:master.

[Christian Brabandt]

please contact the runtime script maintainer and discuss the issue with him.

[James Sully]

I contacted the maintainer and he hasn't responded, so I thought I'd go ahead and bump this, in accordance with CONTRIBUTING.md.
Bump.

[Bram Moolenaar]

It looks like Johannes isn't responding.

Would you perhaps be willing to take over maintenance?

--
hundred-and-one symptoms of being an internet addict:
74. Your most erotic dreams are about cybersex

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[James Sully]

I'd absolutely be willing, the main issue is whether I'm able. I don't
actually know vimscript (this patch is super trivial).

I'd love to learn and give it a shot though. Is there a document somewhere
that outlines the responsibilities and process?

On Thu., 9 Jun. 2016, 6:32 am vim-dev ML, <notifi...@github.com> wrote:

>
> James Sully wrote:
>
> > On Wednesday, 1 June 2016 20:29:42 UTC+10, Christian Brabandt wrote:
> > > please contact the runtime script maintainer and discuss the issue
> with him.
> > >
> > >
> > > —

[Bram Moolenaar]

James Sully wrote:

> I'd absolutely be willing, the main issue is whether I'm able. I don't
> actually know vimscript (this patch is super trivial).
>
> I'd love to learn and give it a shot though. Is there a document somewhere
> that outlines the responsibilities and process?

Just update the file header with your name and email. Send me the file
whenever you make improvements.

If you need help with writing the file the Vim maillist is a good place
to ask questions.

--
hundred-and-one symptoms of being an internet addict:

79. All of your most erotic dreams have a scrollbar at the right side.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

—
You are receiving this because you commented.

[Christian Brabandt]

Am 2016-06-09 09:14, schrieb James Sully:
> I'd absolutely be willing, the main issue is whether I'm able. I don't
> actually know vimscript (this patch is super trivial).
>
> I'd love to learn and give it a shot though. Is there a document
> somewhere
> that outlines the responsibilities and process?

There is no documentation as far as I know. But I think ftplugins
are generally relatively easy to maintain and don't need to be updated
very often. One advise might be to maintain this file as a separate
github repository so others can contribute easily.

Best,
Christian

[James Sully]

Attached :)

And, created https://github.com/sullyj3/vim-ftplugin-python

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to a topic in the Google Groups "vim_dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/vim_dev/VPVdKcsb3SY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to vim_dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Bram Moolenaar]

James Sully wrote:

> Attached :)
>
> And, created https://github.com/sullyj3/vim-ftplugin-python

Thanks.

Let's add the previous maintainer to the header:

" Previous Maintainer: Johannes Zellner <joha...@zellner.org>


--
If your nose runs, and your feet smell, you might be upside down.

[James Sully]

Done!

[vim-dev ML]

I think this can be closed. Reopen, if this issue isn't fixed yet please.

—
You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, .

[vim-dev ML]

Closed #842.

—
You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, .