TSVN fails to show the log of files which have Unicode Hebrew characters in the URL and where the repo has a space in the name

[Yair]

After installing a new version of TSVN (1.13.1) on a new laptop, I noticed that if I try to show the log for a folder or file that has Hebrew characters in it, the request fails like this:

1. The log window appears.
2. I get the "Want to go offline?" modal dialog, which says "There has been a problem contacting the server".
3. I cancel it and it appears again after a couple of seconds.
4. I cancel it again and then the log window shows the error message "Unable to connect to a repository at URL 'XXX' in the revision section
   

The problem with the URL appears to be that the space in the repo name (and only that space) is escaped as %2520 instead of %20, like all the other spaces in the URL.

Simplified example using a local repository with the file protocol, although my actual use is with HTTP:

This only happens if the repo has a space in its name and if the item I click has Hebrew somewhere in the URL (the Hebrew characters themselves are escaped as %D7%90 through %D7%AA, which doesn't actually seem to be a valid range for Unicode, but seems to work correctly and has done so for years). I haven't tested other languages.

The same issue happens if I ask for the log from the repo browser.

If I right click the file/folder in either window and ask to copy the URL to the clipboard, it is copied with the space correctly escaped as %20.

I haven't noticed anything else which is affected by this so far, other than logs. Updates, commits and diffs work correctly, even when applied directly to the file. Logs also show the file correctly if the log is performed on a higher level in the folder structure, where there is no Hebrew.

I haven't seen this issue before now because for the last few years I was using an older version of TSVN (1.9.3 27038 on Windows 10), which doesn't have this issue. I do see the issue on PCs with Windows 10 and TSVN version 1.9.5 build 27581, so I assume it was introduced somewhere in between those two versions.

After uninstalling version 1.9.5 on one of those PCs and installing 1.9.3, it seems to work correctly. I might do that for now or resort to not showing logs directly on things with Hebrew in them.

Probably minor point - when I set up the example shown above, I created two repos (called "repo" and "space repo") and did see that this only happened on the space repo, but when playing around with it I also managed to get it to a point where it did work correctly even on the space repo. I'm not sure what the exact steps were that led to that. This didn't cause other repos to work correctly and I didn't check if it survived a system reboot or anything like that. I did see that even when the space repo worked correctly, the real repo I use still didn't work correctly.

Here are some Hebrew characters, if anyone wants to try to reproduce:

אבגדהוזחטי

You could probably also install a Hebrew language pack on Windows and use the on screen keyboard, and I assume Mac and Linux also have support.

Thanks.

[Stefan]

thanks for the report.

Fixed in r28813.

[hth...@gmail.com]

Thanks for the quick response. I installed the nightly build (1.13.99.28819) on a clean machine and the show log command on a file works correctly.

However, when I looked at the change log, I saw you said this fix was applied to the log dialog bottom pane, so I figured I would test that as well, and that actually still shows the same problem. If I right click the file in Windows Explorer and show the log, I get the correct log window, but if I then right click the file in the bottom pane of that window and ask for the log, I get the same error in the new log window, where the space in the repo name is escaped as %2520.

I actually use the context menu in that pane relatively rarely (although these days I do actually use it more), so this bothers me less, but I figured I would point that out.

[Stefan]

Should work now as of r28822

[hth...@gmail.com]

Thanks, a very cursory test with build 28826 shows both working. Hopefully that caught all of the relevant places.

As a more general thanks, I've been using SVN & TSVN for just over 13 years (first commit in our first repo is from March 2007) and it has been extremely useful, so thanks for that.

[Yair]

OK, I found one more spot where this issue still occurs (1.14.0, Build 28885).

As a reminder, the problem is that in some cases the space in the repo name (and only that space) is escaped as %2520 instead of %20 in URLs.

The current problem is similar to what was fixed in r28822, as it happens in the same context menu. In the bottom pane of the log dialog, right clicking on an item and selecting any of the following still uses the unescaped URL:

1. Compare with working copy
   
2. Open
3. Open with
4. Save revision to (after selecting the folder to save to)
5. Export

The other options in that context menu all seem to use the correct URL. I haven't checked all of the options in the context menu in the top pane, but at least these commands do seem to work correctly from the top pane.

--
You received this message because you are subscribed to a topic in the Google Groups "TortoiseSVN" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/tortoisesvn/bOD2OceFisk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to tortoisesvn...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn/b19548d0-2dd8-448a-87d5-19d76751ed61%40googlegroups.com.

[Yair]

A friendly bump

[Stefan]

r29075

[Yair]

Thanks.

I ran a quick test with build 29082 with the options I listed in the recent message and they seem to work.

On Mon, 8 Feb 2021 at 20:06, Stefan via TortoiseSVN <torto...@googlegroups.com> wrote:

r29075

--
You received this message because you are subscribed to a topic in the Google Groups "TortoiseSVN" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/tortoisesvn/bOD2OceFisk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to tortoisesvn...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn/5ce89bdb-7ef7-43f6-9a3f-78f479f11e8bn%40googlegroups.com.