TW5.1 Theme changes on upgrade

[HowardM]

I have several TW5 files, all using the vanilla theme with a light grey background and white tiddlers without a border.   All but one look exactly the same after upgrade (I am upgrading by using an empty TW5.1 and importing the tiddlers from the existing file).  One, however, switches to a completely white theme with bordered tiddlers when I press the import button on the list of tiddlers to be imported.   The control panel insists this is still the vanilla theme.   

I have excluded all tiddlers starting with "$" from the import, but this makes no difference.   The old file is TW5.014.

I would be grateful for any advice on how I could change this to the old theme with the light grey background & borderless tiddlers.   I am using Firefox.

Cheers

Howard

[PMario]

Did you try: http://tiddlywiki.com/upgrade.html  ?
-m

[Howard Morrison]

PMario

Thanks for the suggestion but the result of using the upgrade page is the same.   The upgrade list I had to approve included upgrades to 5.1 for the Vanilla & Snow White themes, so I am completely puzzled by this.   The wiki is fairly simple   - a modest number of linked notes - with no attempt to change the overall appearance by changing shadow tiddlers etc.

Howard

Sent from my iPad

On 21 Sep 2014, at 08:05, PMario <pmar...@gmail.com> wrote:

Did you try: http://tiddlywiki.com/upgrade.html  ?
-m

--
You received this message because you are subscribed to a topic in the Google Groups "TiddlyWiki" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/tiddlywiki/QTX0pLXixts/unsubscribe.
To unsubscribe from this group and all its topics, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
For more options, visit https://groups.google.com/d/optout.

[Jeremy Ruston]

Hi Howard

Maybe worth checking in Control Panel/Appearance/Palette which palette you've got selected for the faulty wiki - ensure that you've switched to the vanilla palette.

Best wishes

Jeremy

--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.

To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
For more options, visit https://groups.google.com/d/optout.

--
Jeremy Ruston
mailto:jeremy...@gmail.com

[Howard Morrison]

Jeremy

Thanks for the suggestion but still no luck.

In the end, because it is a small wiki, I dragged across tiddlers one by one into TW5.1 until I found the culprit.  It turned out to be a wiki text macro with CSS in it - it wasn't important so I simply excluded it from the upgraded wiki.

Regards

Howard

Sent from my iPad

[PMario]

On Monday, September 22, 2014 11:27:52 AM UTC+2, HowardM wrote:

In the end, because it is a small wiki, I dragged across tiddlers one by one into TW5.1 until I found the culprit.  It turned out to be a wiki text macro with CSS in it

... but that's interesting. may be a bug. .. So can you post your "offensive macro" with the CSS in it ?

-m

[HowardM]

Hi PMario

I am not sure how to attach the tiddler (which I got from one of the TW sites) but its title is "colour" and tagged "macro" and "$:/tags/Macro".

The text is simply:

\define colour(color,text)

@@color:$color$;

$text$

@@

\end

I am not sure whether it is relevant, but only four tiddlers had been loaded into TW5.1 when the theme change occurred and that did not include the tiddler calling this macro . 

Regards

Howard

[PMario]

On Monday, September 22, 2014 6:23:51 PM UTC+2, HowardM wrote:

I am not sure how to attach the tiddler (which I got from one of the TW sites) but its title is "colour" and tagged "macro" and "$:/tags/Macro".

The text is simply:

\define colour(color,text)

@@color:$color$;

$text$

@@

\end

I am not sure whether it is relevant, but only four tiddlers had been loaded into TW5.1 when the theme change occurred and that did not include the tiddler

calling this macro . 

 
Nice! I can replicate it :) ... colour is a global system macro used in the default themes. ... So tagging the tiddler with $:/tags/Macro ... overwrites it. ... So the global macro handler imo needs a "blacklist" that tells the user, that he is going to overwrite a system macro...

Thx for the info!
mario

[PMario]

I did create a ticket: https://github.com/Jermolene/TiddlyWiki5/issues/897
May be we can avoid confusion in the future.

btw: if you name you macro differently it should work again: eg: \define colr(color,text)

-m