Contributing to SymPy

[Ben Lucato]

Hello, I've made a couple of posts here asking questions, but now I'd like to start contributing ^^. 

I've gone through the guide to contributing, how to document, etc. and done everything I need to.

I've been writing Python for over a year now, but am very new to things like Git/GitHub.

Two questions I had:

• Yesterday I did a totally new clone+pull of the git master, yet on running tests via ./bin/test, one of the tests fail prompting a *DO NOT COMMIT* message?
• I couldn't find it in the issues tracker, but I'm not sure if I'm searching right anyway - what I'd like to work on is when you do something like solve(x - pi > 0), a NotImplementedError is returned

Yay! SymPy will be the first thing I've contributed to :- )

[Ondřej Čertík]

Hi Ben!

On Wed, Jul 31, 2013 at 7:20 PM, Ben Lucato <ben.l...@gmail.com> wrote:
> Hello, I've made a couple of posts here asking questions, but now I'd like
> to start contributing ^^.

Welcome and awesome!

>
> I've gone through the guide to contributing, how to document, etc. and done
> everything I need to.
>
> I've been writing Python for over a year now, but am very new to things like
> Git/GitHub.
>
> Two questions I had:
>
> Yesterday I did a totally new clone+pull of the git master, yet on running
> tests via ./bin/test, one of the tests fail prompting a *DO NOT COMMIT*
> message?

Can you send the output of the failure? If it fails in master, it's
most definitely a bug
that needs to be fixed asap.

> I couldn't find it in the issues tracker, but I'm not sure if I'm searching
> right anyway - what I'd like to work on is when you do something like
> solve(x - pi > 0), a NotImplementedError is returned
>
>
> Yay! SymPy will be the first thing I've contributed to :- )

We are happy to see you here.

Ondrej

[Ben Lucato]

Ok - I'm not at home at the moment, but when I get home I will re-run the tests and post the relevant output.

--
You received this message because you are subscribed to a topic in the Google Groups "sympy" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/sympy/awNx8CHhWo8/unsubscribe.
To unsubscribe from this group and all its topics, send an email to sympy+un...@googlegroups.com.
To post to this group, send email to sy...@googlegroups.com.
Visit this group at http://groups.google.com/group/sympy.
For more options, visit https://groups.google.com/groups/opt_out.

--

 

 

Ben Lucato

----------------------------------------------------------------------------------

Phone: +61 400 159 632 | Email: ben.l...@gmail.com

[Ben Lucato]

Hey I re-ran the tests. I wasn't sure how much of the output to grab (most of it was successful tests), so I have just copied all of the error output with a bit of the successful tests - it's attached to this post as a text post.

[Ben Lucato]

Oops I mean attached as a text file, not attached as a text post.

[Ondřej Čertík]

Ok, so this is a pyglet bug:

File "c:\Python27\lib\site-packages\pyglet\window\__init__.py", line 686, in _
_init__
self._create()
File "c:\Python27\lib\site-packages\pyglet\window\win32\__init__.py", line 467
, in _create
_user32.RegisterClassW(byref(self._window_class))
WindowsError: exception: access violation reading 0xFFFFFFFFFFFFFFFF

that we cannot do much about. Unfortunately it seems that pyglet is
not actively developed anymore, so maybe we should using something
else, preferably inside the IPython notebook, which is very actively
developed.

Ondrej

> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an

[Aaron Meurer]

Yeah, I ended up uninstalling pyglet because of the bugs that cause
test failures. The pyglet plotting module is already deprecated in
favor of the matplotlib one.

Aaron Meurer

[Ben Lucato]

For the newbie here (me) - how come this isn't reflected in the master branch yet?

You received this message because you are subscribed to a topic in the Google Groups "sympy" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/sympy/awNx8CHhWo8/unsubscribe.
To unsubscribe from this group and all its topics, send an email to sympy+un...@googlegroups.com.

To post to this group, send email to sy...@googlegroups.com.
Visit this group at http://groups.google.com/group/sympy.
For more options, visit https://groups.google.com/groups/opt_out.

--

 

 

[Stefan Krastanov]

Pyglet is not part of sympy, but if installed it can be used for plotting. In your case the test runner detected that you have installed pyglet and ran the appropriate tests. It found a problem with pyglet and it raised an error. The thing is, the problem is not in sympy, it is in pyglet, so there is not much that we can do. If you do not use it, you can just uninstall it (however I do not know how to do this on windows).

[Ben Lucato]

Oh right, so the tests only run if you have pyglet installed. That's how they got in the master. Thanks