Are there contributor guidelines?

27 views
Skip to first unread message

Julia Evans

unread,
Mar 21, 2013, 4:48:31 PM3/21/13
to sumatr...@googlegroups.com
I just started using Sumatra a few days ago. I think it's an amazing idea, and it's already been very helpful to me! I've run into a few issues, though (the most recent three at http://neuralensemble.org/trac/sumatra/timeline). So far I've hacked the Sumatra source to get around them, but I'd like to try actually fixing them.

Is there anything I should know before trying to fix them? I tried to run the tests by running 'nosetests', but I got a lot of errors (attached), so I suspect that wasn't the right way. 

cheers,
Julia
nose_errors.txt

Andrew Davison

unread,
Mar 21, 2013, 5:30:40 PM3/21/13
to sumatr...@googlegroups.com
Hi Julia,


On Thursday, 21 March 2013 21:48:31 UTC+1, Julia Evans wrote:
I just started using Sumatra a few days ago. I think it's an amazing idea, and it's already been very helpful to me! I've run into a few issues, though (the most recent three at http://neuralensemble.org/trac/sumatra/timeline). So far I've hacked the Sumatra source to get around them, but I'd like to try actually fixing them.

That would be great!
 
Is there anything I should know before trying to fix them?

The developer/contributor guidelines are at http://pythonhosted.org/Sumatra/developers_guide.html
If anything is unclear in the guidelines, please tell me, so I can improve them (or improve them directly by editing doc/developers_guide.txt)
 
I tried to run the tests by running 'nosetests', but I got a lot of errors (attached), so I suspect that wasn't the right way. 

Actually, all of the messages saying 'error' are expected - the tests are deliberately provoking errors, and checking that the expected error messages are produced. The only actual error is indicated by the 'E' in the list of '........' near the bottom. You haven't included the traceback, so I can't see what the actual error was.

Best regards,

Andrew

Julia Evans

unread,
Mar 22, 2013, 7:50:02 AM3/22/13
to sumatr...@googlegroups.com
Thanks so much! I couldn't find the developer's guide before. I don't know why, since it's linked from the project front page :)

Julia



--
You received this message because you are subscribed to a topic in the Google Groups "sumatra-users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/sumatra-users/xnCAtoI3P-8/unsubscribe?hl=en.
To unsubscribe from this group and all its topics, send an email to sumatra-user...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Daniel Wheeler

unread,
Mar 29, 2013, 11:14:11 PM3/29/13
to sumatr...@googlegroups.com
On Thu, Mar 21, 2013 at 5:30 PM, Andrew Davison <andrew....@unic.cnrs-gif.fr> wrote:
Hi Julia,


On Thursday, 21 March 2013 21:48:31 UTC+1, Julia Evans wrote:
I just started using Sumatra a few days ago. I think it's an amazing idea, and it's already been very helpful to me! I've run into a few issues, though (the most recent three at http://neuralensemble.org/trac/sumatra/timeline). So far I've hacked the Sumatra source to get around them, but I'd like to try actually fixing them.

That would be great!
 
Is there anything I should know before trying to fix them?

The developer/contributor guidelines are at http://pythonhosted.org/Sumatra/developers_guide.html
If anything is unclear in the guidelines, please tell me, so I can improve them (or improve them directly by editing doc/developers_guide.txt)


Andrew, On a related note, I noticed that "python setup.py develop" doesn't seem to work correctly. I think this is related to using "src/" as the source directory instead of "sumatra/", which is more canonical for Python packages. Basically, the "develop" command puts a place holder in "easy-install.pth" and at the moment it just links to the base of the Sumatra repository so "import sumatra" doesn't work, but "import src" does work. Maybe there is a way around this, but I'm not sure. One solution is to just rename "src/" to "sumatra/". What do you think?
 

--
Daniel Wheeler

Andrew Davison

unread,
Apr 2, 2013, 5:02:00 AM4/2/13
to sumatr...@googlegroups.com
Hi Daniel,

> Andrew, On a related note, I noticed that "python setup.py develop"
> doesn't seem to work correctly. I think this is related to using
> "src/" as the source directory instead of "sumatra/", which is more
> canonical for Python packages. Basically, the "develop" command puts
> a place holder in "easy-install.pth" and at the moment it just links
> to the base of the Sumatra repository so "import sumatra" doesn't
> work, but "import src" does work. Maybe there is a way around this,
> but I'm not sure. One solution is to just rename "src/" to
> "sumatra/". What do you think?

I always just create a symbolic link to "src" in "site-packages" with
the name "sumatra", but on the principle of least surprise I agree we
should rename "src" to "sumatra" in the repository. I'll do that soon.

Cheers,

Andrew

Reply all
Reply to author
Forward
0 new messages