pull request for advi?

[Alp Kucukelbir]

hi all,

i've been working closely with daniel to polish advi and the tests that accompany it.

i'm feeling like it's probably a good time to start thinking about merging this into develop. i could then start a separate branch and start hacking at the thing that excites me more, which is the stochastic/data-subsampling variant of the algorithm.

cheers
alp

[Bob Carpenter]

If it's OK with Daniel as far as testing and code or goes,
it's almost certainly going to be OK with the rest of us.

Same thing with Michael and being OK with the ongoing
command refactor.

I'm happy to code review if you make the pull request.

- Bob

> --
> You received this message because you are subscribed to the Google Groups "stan development mailing list" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to stan-dev+u...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Alp Kucukelbir]

thanks bob.

ok, so i'll ping michael to take a look. with his approval,
i'll start the pull request.

cheers
alp

> You received this message because you are subscribed to a topic in the Google Groups "stan development mailing list" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/stan-dev/Q_P-GXtBhdc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to stan-dev+u...@googlegroups.com.

[Bob Carpenter]

You should go ahead and create the pull request and then
ask for feedback. It's easier to comment that way. If
you update the branch, the pull request is automatically
updated --- it's a request to merge a branch into another
branch, not a commit into a branch.

The tests automatically run with each push to the branch once
you have a pull request (unless Jenkins gets into a snit,
which is quite often).

- Bob

[Alp Kucukelbir]

great! i created the pull request!

cheers
alp