Reviewboard Perforce Support

[randy_m...@petroglyphgames.com]

Hi,

I'm having a lot of issues getting a test copy of Reviewboard set up to work with Perforce. On the server I've configured it correctly but I can only do local review requests. I've selected Repository type, copied my p4path into the path there, and correctly entered my user name and password.

On the client side I can't get rbt post to work. It keeps saying: ERROR: The current directory does not contain a checkout from a supported source code repository.

p4info works and shows:
User name: Randy_Martinez
Client name: RANDY-M-PC1
Client host: RANDY-M-PC1
Client unknown.
Current directory: c:\Projects\vr
Peer address: 10.2.10.75:49727
Client address: 10.2.10.75
Server address: serena.pg.loc:3850
Server root: /opt/scsi_perforce
Server date: 2016/12/06 16:19:06 -0800 PST
Server uptime: 1926:30:21
Server version: P4D/LINUX26X86_64/2015.2/1264740 (2015/11/11)
Server license: Petroglyph Games Inc 122 users (support expired 2015/12/14)
Server license-ip: 10.2.10.7:3850
Case Handling: sensitive

According to the documentation I just need to type rbt post [changelist number]: https://www.reviewboard.org/integrations/perforce/

Does anyone have any insights?

Thanks!

[David Trowbridge]

Can you run rbt post with --debug and send us the output?

-David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[randy_m...@petroglyphgames.com]

Sure:
>>> RBTools 0.7.7
>>> Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel)]
>>> Running on Windows-8-6.2.9200
>>> Home = C:\Users\Randy_Martinez\AppData\Roaming
>>> Current directory = C:\Projects\vr
>>> Command line: rbt post --debug
>>> Checking for a Subversion repository...
>>> Unable to execute "svn help": skipping SVN
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
>>> Checking for a Mercurial repository...
>>> Unable to execute "hg --help": skipping Mercurial
>>> Checking for a CVS repository...
>>> Unable to execute "cvs": skipping CVS
>>> Checking for a Perforce repository...
>>> Running: p4 info
>>> Checking for a Plastic repository...
>>> Unable to execute "cm version": skipping Plastic
>>> Checking for a ClearCase repository...
>>> Unable to execute "cleartool help": skipping ClearCase
>>> Checking for a Bazaar repository...
>>> Unable to execute "bzr help": skipping Bazaar
>>> Checking for a Team Foundation Server repository...
>>> Unable to execute "tf help": skipping TFS

ERROR: The current directory does not contain a checkout from a supported source code repository.

It ran p4 info fine according to the logs. My guess is it's not parsing p4 info correctly.

[Trent Tuggle]

Bump... is there any resolution to this problem?  I've encountered the same problem.

[David Trowbridge]

Are you running "rbt post" from within a perforce client?

-David

On Wed, Feb 8, 2017 at 9:35 AM Trent Tuggle <tr...@tuggle.org> wrote:

Bump... is there any resolution to this problem?  I've encountered the same problem.

--

[Trent Tuggle]

Hi David,

Thanks for your question.  It fails both within Perforce clients and without.  It fails either way.

I’m on a mac, and I’ve successfully set up rbt on a Windows PC, but I’m not a Python guy so I’m having a hard time debugging what’s wrong.

1. I first installed the RBTools using the Mac installer, which apparently is Python 2.6-based.  That didn’t work, because it immediately died not having found ‘argparser’.
2. I tried using easy_install to install argparser, but then rbt died on something else (forget what).
3. I then tried removing all those installed artifacts, then installing pip on Pythong 2.7, and using pip to install RBTools.
4. Pip had a problem because it found the ‘six’ package already installed… it’s unclear if it came with my Mac or was installed as a part of previous attempts here.
5. I finally got rbt installed via PIP by adding '--ignore-installed six’ to the cmd-line.

-Trenton

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/h2wxLlTBtkg/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.

[Christian Hammond]

Hey Trenton,

Speaking to the installation issues (not Perforce), Python compatibility on Mac is finicky in terms of installation paths. When using the installer, and depending on the system setup, you can hit various problems. I'm sorry you hit so many. I've been fighting this and recently put a good set of fixes together, which will be in the next release's installer.

Christian

--

-- 
Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Jessie Qiu]

Christian,

I went through the same painful troubleshooting path and stuck at this error too.  I'm using latest tool 0.7.9. My mac OS is 10.12.2 (Sierra).  Please let me know if this will be fixed in next release.

Thanks!
Jessie


jessie-macbook:Jessie_macbook_release jessie1$ rbt post -d
>>> RBTools 0.7.9
>>> Python 2.7.13 (default, Dec 18 2016, 07:03:39)
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]
>>> Running on Darwin-16.3.0-x86_64-i386-64bit
>>> Home = /Users/jessie1
>>> Current directory = /Users/jessie1/DevTrees/Streams/Jessie_macbook_release
>>> Command line: rbt post -d

>>> Checking for a Subversion repository...

>>> Running: svn --non-interactive info
>>> Command exited with rc 1: ['svn', '--non-interactive', u'info']
svn: E155007: '/Users/jessie1/DevTrees/Streams/Jessie_macbook_release' is not a working copy
---

>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
>>> Checking for a Mercurial repository...
>>> Unable to execute "hg --help": skipping Mercurial
>>> Checking for a CVS repository...
>>> Unable to execute "cvs": skipping CVS
>>> Checking for a Perforce repository...
>>> Running: p4 info
>>> Checking for a Plastic repository...
>>> Unable to execute "cm version": skipping Plastic
>>> Checking for a ClearCase repository...
>>> Unable to execute "cleartool help": skipping ClearCase
>>> Checking for a Bazaar repository...
>>> Unable to execute "bzr help": skipping Bazaar
>>> Checking for a Team Foundation Server repository...
>>> Unable to execute "tf help": skipping TFS
ERROR: The current directory does not contain a checkout from a supported source code repository.

[Trent Tuggle]

One strategy that ReviewBoard may want to consider is simply updating the port in MacPorts.  That way, people can easily install MacPorts, then install py-rbtools through that.  It can help insure the right versions of everything are installed in suitable locations.

Unfortunately the current MacPorts port of ReviewBoard is 0.4.3, which is the old post-review version:

py-rbtools @0.4.3 (python, devel)
Sub-ports:            py27-rbtools

Description:          Tools for integrating with Review Board, a powerful web-based code review tool
                      that offers developers an easy way to handle code reviews. This package
                      provides "post-review", a command-line tool that simplifies both creating and
                      updating review requests.
Homepage:             http://www.reviewboard.org/

Library Dependencies: py27-rbtools
Platforms:            darwin
License:              MIT
Maintainers:          none