Review Board 2.5 beta 2 is out!

[Christian Hammond]

Hey everyone,

We've put out the second beta of Review Board 2.5. We're hoping to wrap this release cycle up soon, get an RC out the door in the next two weeks and then ship the final 2.5 release shortly after. We'd love your testing to help make this happen.

You can read our announcement, complete with screenshots, here: https://www.reviewboard.org/news/2015/07/20/review-board-2-5-beta-2-out/

We also have an announcements mailing list available, for those not on it: https://www.reviewboard.org/mailing-lists/

And as a reminder, we're posting the latest development news, feature additions, design ideas, etc. over at the Review Board ChangeLog: http://changelog.assembly.com/reviewboard

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org

Beanbag, Inc. - https://www.beanbaginc.com

[Stephen Gallagher]

On Mon, Jul 20, 2015 at 1:30 PM Christian Hammond <chri...@beanbaginc.com> wrote:

Hey everyone,

We've put out the second beta of Review Board 2.5. We're hoping to wrap this release cycle up soon, get an RC out the door in the next two weeks and then ship the final 2.5 release shortly after. We'd love your testing to help make this happen.

You can read our announcement, complete with screenshots, here: https://www.reviewboard.org/news/2015/07/20/review-board-2-5-beta-2-out/

We also have an announcements mailing list available, for those not on it: https://www.reviewboard.org/mailing-lists/

And as a reminder, we're posting the latest development news, feature additions, design ideas, etc. over at the Review Board ChangeLog: http://changelog.assembly.com/reviewboard

I've also created a new COPR repository for Fedora 21+ and RHEL/CentOS 7. You can now download and install Review Board 2.5 beta 2 for evaluation on those platforms. Browse to https://copr.fedoraproject.org/coprs/sgallagh/reviewboard2.5/ and install the appropriate repository file into /etc/yum.repos.d, then do 'yum install ReviewBoard'. If you already have Review Board on the target system, back it up and then just do 'yum update ReviewBoard' (after having installed the repo file, of course).

Yum may prompt you to accept the signing key for these new packages; that key should be:

 f836 fa56 6e04 caa8 832f 6efd fa1d d63c 353c 6a28

[Paul Fee]

Hi Christian,

I see this line in the 2.5 Beta 2 release notes:

* Diff Viewer - Fixed some problems with interdiffs resulting from rebased changes

Are these fixes applicable to the 1.7 release branch?

Thanks,
Paul

[gja...@clearpathrobotics.com]

Is there an upgrade path from beta1 to beta2? 

Running into the following error trying an upgrade ( I'll debug further if sane path - else if not supported assuming nuke the Django site and leave db in place?)

The upgrade fails at:

 File "/tmp/easy_install-LxFRjB/ReviewBoard-2.5b2/reviewboard/reviews/fields.py", line 9, in <module>
    from djblets.markdown import iter_markdown_lines
django.core.exceptions.ImproperlyConfigured: Error importing module djblets.extensions.staticfiles: "No module named markdown"
Traceback (most recent call last):
  File "/usr/bin/easy_install", line 9, in <module>
    load_entry_point('setuptools==3.3', 'console_scripts', 'easy_install')()

[Greg Jacobs]

I should also note, I do have markdown installed and working correctly etc. Beta1 ran fine prior. 

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/Mv4Y183SAVM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Greg Jacobs | Test Engineering Manager  | Clearpath Robotics, Inc.
1425 Strasburg Rd., Suite 2A, Kitchener, Ontario N2R 1H2 Canada
T:  519-513-2416 x861  | E: gja...@clearpathrobotics.com  | W: www.clearpathrobotics.com

Your Unmanned Experts ^TM

[gja...@clearpathrobotics.com]

Pasted full logs here if that helps... Let me know how I can be of assistance. 

http://pastebin.com/kRqq6vfG

[Christian Hammond]

Hi,

Looks like for whatever reason, your install pulled down an old version of Djblets. It should have grabbed 0.9 beta 2, not beta 1.

The whole install process in your log looks questionable, though. It pulled down the .tar.gz and not the .egg, which I'm surprised about. So, that's also a problem. Review Board cannot be installed from a .tar.gz without a bunch of extra packaging tools for the CSS/JavaScript also being installed.

What does `easy_install --version` say?

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org

Beanbag, Inc. - https://www.beanbaginc.com

[Christian Hammond]

Hi Paul,

These fixes are not. Interdiffs were largely rewritten since 1.7 and behave differently. We've had further changes since 2.0 (though we may backport some of these fixes).

Are there particular fixes you're interested in?

Christain

--
Christian Hammond - chi...@chipx86.com

Review Board - https://www.reviewboard.org

Beanbag, Inc. - https://www.beanbaginc.com

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---

You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

[Greg Jacobs]

# easy_install --version

setuptools 3.3

[Christian Hammond]

Ah, looks like the problem is due to the package name you used. You want "ReviewBoard" (or "ReviewBoard==2.5b2") and not "ReviewBoard-2.5b2". The latter isn't being found as a package name, and it's trying hard to fulfill the request by finding a source tarball matching the name given as a last resort.

If you hit further problems, it's also probably worth upgrading your version to setuptools (18.0.1 is the latest), as a lot has changed involving package versioning and location since 3.3.

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org

Beanbag, Inc. - https://www.beanbaginc.com

You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

[Greg Jacobs]

That did the trick ( "ReviewBoard==2.5b2") ... so PEBKAC on my end. Thanks all!

So I upgraded a test 2.5 beta1 system to beta2 by doing the following for reference by others - you can give this blessing or scream that its a bad idea:

sudo service apache2 stop

sudo easy_install \

    -f http://downloads.reviewboard.org/releases/ReviewBoard/2.5/ \

    -U ReviewBoard==2.5b2

sudo rb-site upgrade /var/www/your-existing-install-location

As far as output if anyone is curious...
------------------ <begin log output> ------------------
Creating tables ...
Upgrading Review Board from 2.5 beta 1 to 2.5 beta 2
There are unapplied evolutions for accounts.
There are unapplied evolutions for reviews.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Evolution successful.
------------------- <end log output> -------------------

Things seem to work fine, will continue to test on my end. Cheers.

[Christian Hammond]

Glad to hear it!

That looks correct. You don't actually need to stop Apache, but it certainly doesn't hurt as far as the upgrade process goes.

Let us know if you hit any bugs! Hoping to get RC out in a couple weeks.

Christian 

--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

-----Original Message-----
From: Greg Jacobs <gja...@clearpathrobotics.com>
Reply: revie...@googlegroups.com <revie...@googlegroups.com>>
Date: July 22, 2015 at 2:32:12 PM
To: revie...@googlegroups.com <revie...@googlegroups.com>>
Cc: reviewb...@googlegroups.com <reviewb...@googlegroups.com>>
Subject:  Re: Review Board 2.5 beta 2 is out!

> That did the trick ( "ReviewBoard==2.5b2") ... so PEBKAC on my end. Thanks
> all!
>
> So I upgraded a test 2.5 beta1 system to beta2 by doing the following for
> reference by others - you can give this blessing or scream that its a bad
> idea:
>
> sudo service apache2 stop
> sudo easy_install \
> -f http://downloads.reviewboard.org/releases/ReviewBoard/2.5/ \
> -U ReviewBoard==2.5b2
> sudo rb-site upgrade /var/www/your-existing-install-location
>
> As far as output if anyone is curious...

> ------------------ ------------------

> Creating tables ...
> Upgrading Review Board from 2.5 beta 1 to 2.5 beta 2
>
>

> *There are unapplied evolutions for accounts.There are unapplied evolutions
> for reviews.Project signature has changed - an evolution is required*

> Installing custom SQL ...
> Installing indexes ...
> Installed 0 object(s) from 0 fixture(s)
> Evolution successful.

> ------------------- -------------------

> >>>>> wrote:
> >>>>>
> >>>>>> Is there an upgrade path from beta1 to beta2?
> >>>>>>
> >>>>>> Running into the following error trying an upgrade ( I'll debug
> >>>>>> further if sane path - else if not supported assuming nuke the Django site
> >>>>>> and leave db in place?)
> >>>>>>
> >>>>>> The upgrade fails at:
> >>>>>>
> >>>>>>>
> >>>>>>> File
> >>>>>>> "/tmp/easy_install-LxFRjB/ReviewBoard-2.5b2/reviewboard/reviews/fields.py",
> >>>>>>> line 9, in

> >>>>>>> from djblets.markdown import iter_markdown_lines
> >>>>>>> django.core.exceptions.ImproperlyConfigured: Error importing module
> >>>>>>> djblets.extensions.staticfiles: "No module named markdown"
> >>>>>>> Traceback (most recent call last):
> >>>>>>> File "/usr/bin/easy_install", line 9, in

> >>>>> *Greg Jacobs* | Test Engineering Manager | Clearpath Robotics, Inc.

> >>>>> 1425 Strasburg Rd., Suite 2A, Kitchener, Ontario N2R 1H2 Canada

> >>>>> *T: * 519-513-2416 x861 | *E:* gja...@clearpathrobotics.com | *W:*
> >>>>> www.clearpathrobotics.com
> >>>>> *Your Unmanned Experts **TM *
> >>>>>
> >>>>
> >>>
> >>
> >>
> >> --
> >>
> >> *Greg Jacobs* | Test Engineering Manager | Clearpath Robotics, Inc.

> >> 1425 Strasburg Rd., Suite 2A, Kitchener, Ontario N2R 1H2 Canada

> >> *T: * 519-513-2416 x861 | *E:* gja...@clearpathrobotics.com | *W:*
> >> www.clearpathrobotics.com
> >> *Your Unmanned Experts **TM *

> *Greg Jacobs* | Test Engineering Manager | Clearpath Robotics, Inc.

> 1425 Strasburg Rd., Suite 2A, Kitchener, Ontario N2R 1H2 Canada

> *T: * 519-513-2416 x861 | *E:* gja...@clearpathrobotics.com | *W:*
> www.clearpathrobotics.com
> *Your Unmanned Experts **TM *

[Paul Fee]

Hi Christian,

I occasionally see bugs when using "rbt post" to push up multiple drafts before I publish.  I suspect that a previous draft is cached server side, browser cache clearing and memcached restarts fail to fix the issue.  Repeat use of "rbt post" following local code changes doesn't always result in visible changes on the interdiff web page.  I haven't been able to reliably reproduce this and can't share the specific diffs in question as the code is private.

Also, I've seen occasions where I can see the change in the side-by-side diff viewer (e.g. lines deleted), however the lines are not always colour coded to highlight the change as expected.

I'm using RB 2.0.18.

Sorry, I just noticed I previously asked if the 2.5 interdiff changes were relevant for RB1.7, I should have asked if they were relevant to RB2.0 as that's the version I've had interdiff viewing problems with.

Thanks,
Paul

[Greg Jacobs]

One other note. I had to re-assert group ownership on the RB site, it was breaking LDAP auth. 

sudo chgrp -R www-data /var/www/your-site-name

I was getting the following in debug logs...

2015-07-23 13:35:57,514 - WARNING -  - LDAP error: {'info': 'invalid DN', 'desc': 'Invalid DN syntax'}

This seemed to resolve my issue. Had noticed (I was root when doing update) root had group perms to assets again. 

[Christian Hammond]

Ah okay, that makes more sense.

I've had reports of both issues. I've been spending time on the interdiff issue, and I know what's wrong. A bit tricky to fix, but I'm aiming for 2.0.19 for a fix there.

For the caching issue, I need a solid, reliable retro case. I've tried debugging this before, but can't make it happen, and all caching keys should guarantee that replaced content would invalidate the cache.

Let me know if you do manage to have a repro case, and we'll look into it further.

Christian

--

-- 
Christian Hammond - chri...@beanbaginc.com

[Greg Jacobs]

Another bug noticed during index cron job execution with the beta2 2.5 release:

Output from command "/usr/bin/python" "/usr/local/bin/rb-site" manage "/var/www/reviews.clearpathrobotics.com" update_index -- -a 1 ..

Indexing 11 users
Indexing 1 review requests
Exception TypeError: TypeError('isinstance() arg 2 must be a class, type, or tuple of classes and types',) in <bound method Signal._remove_receiver of <django.dispatch.dispatcher.Signal object at 0x7f9b106be750>> ignored

Looks like index data was generated:

drwxr-xr-x 2 www-data www-data  4096 Jul 24 15:06 .

drwxr-xr-x 4 www-data www-data  4096 Jul 24 14:49 ..

-rw-r--r-- 1 www-data www-data  7598 Jul 24 15:06 _MAIN_2.toc

-rw-r--r-- 1 www-data www-data 32089 Jul 24 15:06 MAIN_lus9ypwhsxh8aoou.seg

-rw-r--r-- 1 www-data www-data 16268 Jul 24 15:06 MAIN_rwa5uuswnd19j6kl.seg

-rwxr-xr-x 1 www-data www-data     0 Jul 24 15:06 MAIN_WRITELOCK

If you want logs let me know (do you want me to file in bug tracking instead?)

I can also confirm same error with second cron job that cleans up old sessions etc...

Output from command "/usr/bin/python" "/usr/local/bin/rb-site" manage "/var/www/reviews.clearpathrobotics.com" clearsessions ..

Exception TypeError: TypeError('isinstance() arg 2 must be a class, type, or tuple of classes and types',) in <bound method Signal._remove_receiver of <django.dispatch.dispatcher.Signal object at 0x7f8819587750>> ignored

[Christian Hammond]

It's a harmless warning due to some garbage collection and some registered signals. I tried fixing this once, but didn't have luck.

Can you file a bug on this, to help track it?

Thanks!

Christian

--

---
You received this message because you are subscribed to the Google Groups "reviewboard-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-d...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--