Exclude in .reviewboardrc

752 views
Skip to first unread message

anoop kc

unread,
Dec 28, 2014, 10:37:39 AM12/28/14
to revie...@googlegroups.com
Hi,

Could you please advise me on adding an exclude list to the .reviewboardrc file

David Trowbridge

unread,
Dec 28, 2014, 6:45:10 PM12/28/14
to reviewboard
See https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/post/#cmdoption-rbt-post-X

You would set EXCLUDE_PATTERNS to a list of patterns. Note that this is only available in git master (which will ship as 0.7)

-David

On Sun, Dec 28, 2014 at 8:37 AM, anoop kc <an...@baabte.com> wrote:
Hi,

Could you please advise me on adding an exclude list to the .reviewboardrc file

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Jeff Buzzell

unread,
May 4, 2015, 4:27:33 PM5/4/15
to revie...@googlegroups.com
Could you please elaborate on the syntax for patterns when using  .reviewboardrc EXCLUDE_PATTERNS ?

I am able to use the rbt parameters to exclude a single pattern at the Windows command line

    rbt post --exclude *\AssemblyInfo.cs

this successfully excludes all "AssemblyInfo.cs" files found throughout all subfolders.

But when I place this same pattern in the .reviewboardrc file as 

    EXCLUDE_PATTERNS = '*\AssemblyInfo.cs'

and run 

    rbt post

I get this error

    ERROR: There don't seem to be any diffs!

How should patterns be supplied in the .reviewboardrc?  Can multiple patterns be specified somehow?

Thank you.

Barret Rennie

unread,
May 4, 2015, 5:53:41 PM5/4/15
to revie...@googlegroups.com
Hi there Jeff,

When using exclude patterns in your .reviewboardrc file, it takes a list of python strings. As such you have to make sure to either escape your strings correctly or use raw strings.

To use your example, it should be:

EXCLUDE_PATTERNS = [
    r’*\AssemblyInfo.cs’
]

Let me know if this solves your issue.

Regards,
Barret Rennie
--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/

Jeff Buzzell

unread,
May 5, 2015, 11:16:45 AM5/5/15
to revie...@googlegroups.com
Barret,

This works for me.  Thank you for your help.

EXCLUDE_PATTERNS = [
    r'*\AssemblyInfo.cs',
    r'*\Controllers\*',
    r'*\Test\*'
]

Jack Andy

unread,
Dec 11, 2016, 10:49:05 AM12/11/16
to reviewboard
Hi Barret,

I can exclude some certain directories and files by using your method, generally I exclude some .docx binary files.
but In one svn repository, it doesn't work for this, and other repos work fine, and these repos are in the same linux server.

when it doesn't work,  the error is: Binary files tags/test/test.docx revision(13335) differ
svn: E200012: 'diff' returned 2

If it works fine, the upper error doesn't display.


why it only doesn't work in this repository?

Barret Rennie

unread,
Dec 12, 2016, 3:17:55 PM12/12/16
to revie...@googlegroups.com
Hi Jack,

Can you please run rbt post --debug and include that with your entire command line (rbt post --debug -X ...)? If you use EXCLUDE_PATTERNS, please include those as well.

Regards,
Barret

Jack Andy

unread,
Dec 20, 2016, 10:25:08 AM12/20/16
to revie...@googlegroups.com
Hi barret,

thanks for your reply!

After I use "rbt post --debug ..." parameter, then I get an error: "svn: E200012: 'diff' returned 2"



To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/CzBDY5VXXDw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscribe@googlegroups.com.

Jack Andy

unread,
Dec 20, 2016, 11:09:49 AM12/20/16
to revie...@googlegroups.com
the following is the specific error,






Jack Andy

unread,
Dec 20, 2016, 11:12:41 AM12/20/16
to revie...@googlegroups.com
the following is the error,





Reply all
Reply to author
Forward
0 new messages