Issue buttons not working

Yugesh Kambham

unread,

Jun 11, 2014, 2:24:42 PM6/11/14

to revie...@googlegroups.com

Hello.

We go into a strange situation where issue - drop, resolve buttons are not working consistently. We have a review with 10 images attached with over 160 issues(76 open), when I(owner of review) try to drop/resolve/add comment to an open issue nothing is happening, reviewboard is not letting to do anything with the issues. Strange thing is all latest issues are working fine and old issues(6 days back) are not working. Sometimes the buttons are disabled too. Reviewboard is not logging any of this issues in log file and it has become hard to triage any more. I tried multiple browsers, cleared cache, cookies but with mo luck. Can some help please help me fix this?

Thanks,

Yugesh

Christian Hammond

unread,

Jun 11, 2014, 4:57:16 PM6/11/14

to revie...@googlegroups.com

Hi,

What version of Review Board is this? And what version of what browser?

Can you check the browser’s JavaScript console log when you attempt to modify an issue and see if any errors appear?

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Yugesh Kambham

unread,

Jun 11, 2014, 5:51:24 PM6/11/14

to revie...@googlegroups.com, chri...@beanbaginc.com

We are using v1.7.7.1. We tried IE10 and Chrome v35.0.1916.15 .

Console log :

POST https://xxx/reviewboard/api/review-requests/42036/reviews/67932/file-attachment-comments/ 400 (BAD REQUEST) jquery-1.8.2.min.cfa9051cc0b0.js:2

Uncaught TypeError: Cannot read property 'id' of undefined base.min.41cb8c843476.js:91

there were about 10 of above errors.

Christian Hammond

unread,

Jun 11, 2014, 5:53:12 PM6/11/14

to revie...@googlegroups.com

Hi Yugesh,

First thing I’d ask that you do is upgrade to something modern. 1.7.7.1 is from April of 2013, and we’ve made a lot of fixes in that time.

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

Yugesh Kambham

unread,

Jun 11, 2014, 5:58:42 PM6/11/14

to revie...@googlegroups.com, chri...@beanbaginc.com

Upgrading would be big thing for us considering the other priorities, but we do have it in our plan. What do you think caused this? We have around 13 new files and 13 old files as of now on same review and over 70 issues open. Does size of review failing this? Reviews seem to be working fine with moderately less file attachments and started degrading. All other reviews are working fine too except this one.

Yugesh

Christian Hammond

unread,

Jun 11, 2014, 6:00:09 PM6/11/14

to revie...@googlegroups.com

I can’t imagine what would have caused this aside from some issue on your server.

Can you open the Network tab in Chrome’s developer tools, repeat a request, and show what the resulting payload looks like?

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

Yugesh Kambham

unread,

Jun 11, 2014, 6:05:50 PM6/11/14

to revie...@googlegroups.com, chri...@beanbaginc.com

Yes see below.

file-attachment-comments/

/reviewboard/api/review-requests/42036/reviews/68007

POST

400

BAD REQUEST

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

510 B

140 B

178 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68007/file-attachment-comments/738

GET

404

NOT FOUND

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

437 B

70 B

277 ms

276 ms

Christian Hammond

unread,

Jun 11, 2014, 6:06:34 PM6/11/14

to revie...@googlegroups.com

I need to see the actual response payload.

Is the failure only on file attachments? Do you ever see it for diffs?

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

Yugesh Kambham

unread,

Jun 11, 2014, 6:10:30 PM6/11/14

to revie...@googlegroups.com, chri...@beanbaginc.com

We never saw it for diffs and this kinds of failures started appearing only with file attachments. See below for all I got in network tab.

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68255

GET

200

OK

application/vnd.reviewboard.org.review+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

749 B

1.3 KB

346 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68255/file-attachment-comments/797

GET

200

OK

application/vnd.reviewboard.org.file-attachment-comment+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

889 B

1.2 KB

283 ms

282 ms

797/

/reviewboard/api/review-requests/42036/reviews/68255/file-attachment-comments

PUT

200

OK

application/vnd.reviewboard.org.file-attachment-comment+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

928 B

1.2 KB

283 ms

282 ms

797/

/reviewboard/api/review-requests/42036/reviews/68255/file-attachment-comments

PUT

200

OK

application/vnd.reviewboard.org.file-attachment-comment+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

924 B

1.2 KB

343 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68224

GET

200

OK

application/vnd.reviewboard.org.review+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

749 B

1.3 KB

218 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68224/file-attachment-comments/767

GET

404

NOT FOUND

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

437 B

70 B

199 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68224/file-attachment-comments/767

GET

404

NOT FOUND

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

437 B

70 B

209 ms

208 ms

file-attachment-comments/

/reviewboard/api/review-requests/42036/reviews/68224

POST

400

BAD REQUEST

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

510 B

140 B

182 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68007

GET

304

NOT MODIFIED

application/vnd.reviewboard.org.review+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

221 B

1.3 KB

221 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68007/file-attachment-comments/742

GET

404

NOT FOUND

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

437 B

70 B

219 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68007/file-attachment-comments/742

GET

404

NOT FOUND

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

437 B

70 B

202 ms

file-attachment-comments/

/reviewboard/api/review-requests/42036/reviews/68007

POST

400

BAD REQUEST

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

510 B

140 B

254 ms

253 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68007/file-attachment-comments/737

GET

404

NOT FOUND

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

437 B

70 B

229 ms

228 ms

?api_format=json

/reviewboard/api/review-requests/42036/reviews/68007/file-attachment-comments/737

GET

404

NOT FOUND

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

437 B

70 B

207 ms

206 ms

file-attachment-comments/

/reviewboard/api/review-requests/42036/reviews/68007

POST

400

BAD REQUEST

application/vnd.reviewboard.org.error+json

jquery-1.8.2.min.cfa9051cc0b0.js:2

Script

510 B

140 B

179 ms

Christian Hammond

unread,

Jun 11, 2014, 6:11:26 PM6/11/14

to revie...@googlegroups.com

You need to click on the one with the 400, and then click Response.

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

Yugesh Kambham

unread,

Jun 12, 2014, 1:13:57 PM6/12/14

to revie...@googlegroups.com, chri...@beanbaginc.com

Sorry for delay in response, see below:

1. Remote Address:

xx.xx.xxx

2. Request URL:

https://xxxxx/reviewboard/api/review-requests/42036/reviews/68007/file-attachment-comments/

3. Request Method:

POST

4. Status Code:

400 BAD REQUEST

5. Request Headersview source

1. Accept:

application/json, text/javascript, */*; q=0.01

2. Accept-Encoding:

gzip,deflate,sdch

3. Accept-Language:

en-US,en;q=0.8

4. Connection:

keep-alive

5. Content-Length:

39

6. Content-Type:

application/x-www-form-urlencoded; charset=UTF-8

7. Cookie:

rbsessionid=7e0d03ae1d4969f169a765692bf2aefc

8. Host:

xxxxx.com

9. Origin:

https://xxxxx

10. Referer:

https://xxxxreviewboard/r/42036/

11. User-Agent:

Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36

12. X-Requested-With:

XMLHttpRequest

6. Form Dataview sourceview URL encoded

1. api_format:

json

2. text:

3. issue_opened:

true

7. Response Headersview source

1. Cache-Control:

max-age=0

2. Connection:

close

3. Content-Language:

en-us

4. Content-Length:

140

5. Content-Type:

application/vnd.reviewboard.org.error+json

6. Date:

Thu, 12 Jun 2014 17:08:32 GMT

7. Expires:

Thu, 12 Jun 2014 17:08:32 GMT

8. Last-Modified:

Thu, 12 Jun 2014 17:08:32 GMT

9. Server:

Apache/2.2.15 (Red Hat)

10. Vary:

Accept,Cookie,Accept-Language

<p class="MsoNormal" style="l
...

Christian Hammond

unread,

Jun 12, 2014, 3:29:27 PM6/12/14

to revie...@googlegroups.com

There’s still no response payload in there. I really need to see what content comes back from the server. You’ll find it under the “Response” (beside the “Headers” tab that you got this data from).

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

--

Yugesh Kambham

unread,

Jun 12, 2014, 6:09:06 PM6/12/14

to revie...@googlegroups.com, chri...@beanbaginc.com

See the attachment for the response.

...

repsonse.png

Christian Hammond

unread,

Jun 12, 2014, 6:14:41 PM6/12/14

to revie...@googlegroups.com

Okay. I’m pretty sure this was fixed in 1.7.8. You’ll need to upgrade. I’d recommend just moving to the latest 1.7.x.

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

--

Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Yugesh Kambham

unread,

Jun 12, 2014, 6:31:44 PM6/12/14

to revie...@googlegroups.com

Thank you !!!

--

Yugesh Kambham

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/CM5bz4aQejc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.

Reply all

Reply to author

Forward