Fedora rawhide: RB Dashboard missing "Edit Columns" button and column styling

[Paul Fee]

Hi all,

On my Fedora rawhide system with RB2.0 the dashboard doesn't look right.

* The column headers are missing their styling.
* The "Edit Columns" button is missing.

I see this with a freshly created site as illustrated below:




There's no issue with RB1.7.25 on Centos6 nor RB2.0.1 hosted at http://demo.reviewboard.org/



I'm suspecting the issue is unique to the Rawhide packages.  Has anyone else seen this or able to reproduce?

Thanks,
Paul

[Stephen Gallagher]

On 05/30/2014 12:57 PM, Paul Fee wrote:
> Hi all,
>
> On my Fedora rawhide system with RB2.0 the dashboard doesn't look right.
>
> * The column headers are missing their styling.
> * The "Edit Columns" button is missing.
>
> I see this with a freshly created site as illustrated below:
>
>
>
>

> There's no issue with RB1.7.25 on Centos6 nor RB2.0.1 hosted at
> http://demo.reviewboard.org/
>
>
>

> I'm suspecting the issue is unique to the Rawhide packages. Has anyone
> else seen this or able to reproduce?
>

I saw that on an instance I created the other day as well. I'll look
into it next week.

[Stephen Gallagher]

Ok, I'm pretty stumped here. There's nothing obviously wrong with the
build [1] [2], but I'm getting output that is apparently *slightly*
malformed, such that neither Chrome or Firefox will render it properly.
I do not have a strong background in HTML/JS, so I can't spot the issue.
I'm attaching the saved page, hopefully someone can take a look and tell
me where I screwed up.


[1]
https://kojipkgs.fedoraproject.org//packages/python-djblets/0.8.1/1.fc21/data/logs/noarch/build.log
[2]
https://kojipkgs.fedoraproject.org//packages/ReviewBoard/2.0.1/1.fc21/data/logs/noarch/build.log

[Paul Fee]

Hi Stephen,

Comparing the HTML using Firefox/Firebug, I see both good and bad pages have the correct HTML to display the "Edit columns" heading.  However the bad page has missing CSS styling.

On Fedora rawhide, with an up to date "locate" database, I can see an empty CSS file that looks suspicious.

$ ls -l `locate datagrid | grep css`
-rw-r--r--. 1 root root 6251 May 27 15:03 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.css
-rw-r--r--. 1 root root 6316 May 27 15:03 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.da6c340af879.css
-rw-r--r--. 1 root root 6316 May 27 02:01 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.6521a0d8b348.css
-rw-r--r--. 1 root root    0 May 27 15:03 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.css
-rw-r--r--. 1 root root    0 May 27 15:03 /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.d41d8cd98f00.css
-rw-r--r--. 1 root root 6251 May 27 02:01 /usr/lib/python2.7/site-packages/djblets/static/djblets/css/datagrid.css

I expect those two empty files are (part of) the problem.

According to "rpm -qf" they're both owned by python-djblets-0.8.1-1.fc21.noarch.

Thanks,
Paul

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/31p7hxUkUX4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Stephen Gallagher]

On 06/02/2014 11:46 AM, Paul Fee wrote:
> Hi Stephen,
>
> Comparing the HTML using Firefox/Firebug, I see both good and bad pages
> have the correct HTML to display the "Edit columns" heading. However
> the bad page has missing CSS styling.
>
> On Fedora rawhide, with an up to date "locate" database, I can see an
> empty CSS file that looks suspicious.
>
> $ ls -l `locate datagrid | grep css`
> -rw-r--r--. 1 root root 6251 May 27 15:03
> /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.css
> -rw-r--r--. 1 root root 6316 May 27 15:03
> /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.da6c340af879.css
> -rw-r--r--. 1 root root 6316 May 27 02:01
> /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.6521a0d8b348.css
> -rw-r--r--. 1 root root 0 May 27 15:03
> /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.css
> -rw-r--r--. 1 root root 0 May 27 15:03
> /usr/lib/python2.7/site-packages/djblets/htdocs/static/djblets/css/datagrid.min.d41d8cd98f00.css
> -rw-r--r--. 1 root root 6251 May 27 02:01
> /usr/lib/python2.7/site-packages/djblets/static/djblets/css/datagrid.css
>
> I expect those two empty files are (part of) the problem.
>
> According to "rpm -qf" they're both owned by
> python-djblets-0.8.1-1.fc21.noarch.
>

Thanks, Paul. I hadn't spotted that. I suspect you're right. Looks like
the minification of datagrid.css may have broken somehow.

[Stephen Gallagher]

With help from Christian, we sorted this out today and got a release of
Djblets 0.8.2 out (with just the one fix for this issue).

I've done a Rawhide build of Djblets (and a rebuild of Review Board to
update the dependency), so it should be available in your local mirror
within 48 hours.

If you want it sooner than that, you can get the raw RPMs from
http://koji.fedoraproject.org/koji/taskinfo?taskID=6919241

I've also kicked off this update in my COPR repository for Fedora 20, so
that will be available shortly there as well.

[Paul Fee]

Thanks Stephen and Christian, I've downloaded the rawhide updates from Koji and confirmed they've fixed this issue.