[pax-exam] Release a 4.10.1 or 4.11.0 now or when?

27 views
Skip to first unread message

Michael Vorburger

unread,
May 8, 2017, 9:41:02 AM5/8/17
to OPS4J, Michael Vorburger
Hello,

In order to be able to benefit from https://ops4j1.jira.com/browse/PAXEXAM-740 in a downstream project, I would be interested in a Pax Exam release some time. It's not super urgent, but was hoping for maybe the next week or two.. if this fits with other ongoing issues on https://ops4j1.jira.com/projects/PAXEXAM?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page&status=unreleased - what are your plans?

Or can I go ahead and just push a pax exam to central as-is now? Latest published is 4.10.0, so shall we have a 4.10.1 next, as there seem to be only 4 small fixes since the 4.10.0. That would be in line with the current 4.10.1-SNAPSHOT in the pom.xml of master .. or do you instead want us to bump master to 4.11.0-SNAPSHOT now, to be in line with JIRA https://ops4j1.jira.com/browse/PAXEXAM-812 and https://ops4j1.jira.com/browse/PAXEXAM-740?

FYI I just looked around JIRA, have closed the confusing https://ops4j1.jira.com/browse/PAXEXAM-805, and don't see anything else in progress for (4.10.1 or) 4.11.0.

BTW in JIRA there are currently 4 open versions (4.11.0, 4.x, 5.0.0 and unscheduled; but no 4.10.1), so prior to a release perhaps the open 4.x issues should perhaps be moved to no version (unscheduled?), and 4.x closed, to avoid confusion?

Tx,
M.

arunan.bala...@interlinksoftware.com

unread,
May 10, 2017, 5:28:11 AM5/10/17
to OPS4J, vorb...@redhat.com


Hi Michael,

we are in the middle of porting our stack to Karaf 4.1.1 and would like to get two patches upstreamed into pax exam if possible; I've not yet got access to the OPS4J Jira to update 815.

https://ops4j1.jira.com/browse/PAXEXAM-723 - my colleague put up a patch https://github.com/NetNow/org.ops4j.pax.exam2/commit/5dc57cb012306b5df53b98680b67c34a9b4d47d2?diff=unified that I think got lost in the noise. The title of the ticket suggests a breaking change to the feature, but the suggested patch has an opt-in option instead.
https://ops4j1.jira.com/browse/PAXEXAM-815 - there is a branch at https://github.com/NetNow/org.ops4j.pax.exam2/tree/configure-karaf-logging-by-backend which has allowed me to get logging from the console when using log4j2.

These would be handy for us. I also think that more and more people are going to hit 815 as they move to Karaf 4.1.x versions, since it uses log4j2. I would be happy to action any feedback regarding these two patches in order to get them merged and released.

Regards,
Arunan

Achim Nierbeck

unread,
May 10, 2017, 7:09:44 AM5/10/17
to op...@googlegroups.com, Michael Vorburger
Hi Arunan, 

I just added you to the jira :) 
welcome aboard. 
Regarding the Pull-Request, could you please make sure they reference the JIRA number, so it's possible to match the PR / git commit with the corresponding Jira entry. 

regards, Achim 

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--

Apache Member
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead
blog <http://notizblog.nierbeck.de/>
Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>

Software Architect / Project Manager / Scrum Master 

Arunan Balasubramaniam

unread,
May 10, 2017, 1:09:15 PM5/10/17
to op...@googlegroups.com


Hi and thank you Achim :)

I have filed https://github.com/ops4j/org.ops4j.pax.exam2/pull/66 which has the Jira reference in the PR title.

The solution was split into three commits with the Jira reference in the last commit that actually implemented the desired feature. I can edit the PR if you like, perhaps add the Jira reference to the other two commit messages or squash them into a single commit?

Cheers,
Arunan
To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.




--

Apache Member
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead
blog <http://notizblog.nierbeck.de/>
Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>

Software Architect / Project Manager / Scrum Master 

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/UzQyEFfKv7o/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+un...@googlegroups.com.

Achim Nierbeck

unread,
May 10, 2017, 2:18:43 PM5/10/17
to op...@googlegroups.com
Hi Aruna,

In that case I think a squash might be nice.
I'm going to give you the access rights later so you can merge this yourself.

Regards. Achim 

Arunan Balasubramaniam

unread,
May 12, 2017, 5:55:10 AM5/12/17
to op...@googlegroups.com

 

Hi Achim,

 

I have  squashed the commits, waited for the CI build to pass and then fast forward merged it to master. Thanks for how responsive you have been with this!

 

Regards,

Arunan Balasubramaniam

unread,
May 12, 2017, 1:28:09 PM5/12/17
to op...@googlegroups.com

 

 

Hi,

 

I owe my colleague an apology as the commit he pushed for PAXEXAM-723 was only meant for discussion rather than merging; I got the wrong end of the stick.

 

We have looked at it again though and are working on a mergable solution at https://github.com/NetNow/org.ops4j.pax.exam2/tree/paxexam-723-with-features which hopefully will be ready for review on Monday. The method seems to work with a quick test, but we will test further and write integration tests for it.

 

Cheers,

Arunan

 

 

 

From: 'Achim Nierbeck' via OPS4J [mailto:op...@googlegroups.com]
Sent: 10 May 2017 12:10
To: op...@googlegroups.com
Cc: Michael Vorburger <vorb...@redhat.com>
Subject: Re: [pax-exam] Release a 4.10.1 or 4.11.0 now or when?

 

Hi Arunan, 

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.


For more options, visit https://groups.google.com/d/optout.



 

--


Apache Member

Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead
blog <http://notizblog.nierbeck.de/>

Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>

 

Software Architect / Project Manager / Scrum Master 

 

--

--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---

You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/UzQyEFfKv7o/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+un...@googlegroups.com.

arunan.bala...@interlinksoftware.com

unread,
May 15, 2017, 11:16:47 AM5/15/17
to OPS4J

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscribe@googlegroups.com.


For more options, visit https://groups.google.com/d/optout.



 

--


Apache Member

Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead
blog <http://notizblog.nierbeck.de/>

Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>

 

Software Architect / Project Manager / Scrum Master 

 

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/UzQyEFfKv7o/unsubscribe.

To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.

arunan.bala...@interlinksoftware.com

unread,
May 16, 2017, 5:20:19 AM5/16/17
to OPS4J, vorb...@redhat.com


Hi Michael,

thank you for holding off. Fixes for the two issues we wanted resolved are now on master.

Regards,
Arunan

Michael Vorburger

unread,
May 16, 2017, 7:02:40 AM5/16/17
to op...@googlegroups.com, Michael Vorburger
On Tue, May 16, 2017 at 11:20 AM, <arunan.bala...@interlinksoftware.com> wrote:


Hi Michael,

thank you for holding off. Fixes for the two issues we wanted resolved are now on master.

cool

Regards,
Arunan



On Wednesday, May 10, 2017 at 10:28:11 AM UTC+1, arunan.bala...@interlinksoftware.com wrote:


Hi Michael,

we are in the middle of porting our stack to Karaf 4.1.1 and would like to get two patches upstreamed into pax exam if possible; I've not yet got access to the OPS4J Jira to update 815.

https://ops4j1.jira.com/browse/PAXEXAM-723 - my colleague put up a patch https://github.com/NetNow/org.ops4j.pax.exam2/commit/5dc57cb012306b5df53b98680b67c34a9b4d47d2?diff=unified that I think got lost in the noise. The title of the ticket suggests a breaking change to the feature, but the suggested patch has an opt-in option instead.
https://ops4j1.jira.com/browse/PAXEXAM-815 - there is a branch at https://github.com/NetNow/org.ops4j.pax.exam2/tree/configure-karaf-logging-by-backend which has allowed me to get logging from the console when using log4j2.

These would be handy for us. I also think that more and more people are going to hit 815 as they move to Karaf 4.1.x versions, since it uses log4j2. I would be happy to action any feedback regarding these two patches in order to get them merged and released.

Regards,
Arunan


On Monday, May 8, 2017 at 2:41:02 PM UTC+1, Michael Vorburger wrote:
Hello,

In order to be able to benefit from https://ops4j1.jira.com/browse/PAXEXAM-740 in a downstream project, I would be interested in a Pax Exam release some time. It's not super urgent, but was hoping for maybe the next week or two.. if this fits with other ongoing issues on https://ops4j1.jira.com/projects/PAXEXAM?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page&status=unreleased - what are your plans?

Or can I go ahead and just push a pax exam to central as-is now? Latest published is 4.10.0, so shall we have a 4.10.1 next, as there seem to be only 4 small fixes since the 4.10.0. That would be in line with the current 4.10.1-SNAPSHOT in the pom.xml of master .. or do you instead want us to bump master to 4.11.0-SNAPSHOT now, to be in line with JIRA https://ops4j1.jira.com/browse/PAXEXAM-812 and https://ops4j1.jira.com/browse/PAXEXAM-740?

back to this point.. I still don't have permission to admin versions and set release dates / close / add new versions in JIRA (Achim?).

More importantly, it seems to me that the project's original intention probably is to release with bumps to the middle version number, not the last minor version, as this would allow patches in the future to the previous release version?

I've therefore just raised https://github.com/ops4j/org.ops4j.pax.exam2/pull/69 to bump master from 4.10.1-SNAPSHOT to 4.11.0-SNAPSHOT in, with the intention of releasing what is now on master as 4.11.0.

FYI I just looked around JIRA, have closed the confusing https://ops4j1.jira.com/browse/PAXEXAM-805, and don't see anything else in progress for (4.10.1 or) 4.11.0.

BTW in JIRA there are currently 4 open versions (4.11.0, 4.x, 5.0.0 and unscheduled; but no 4.10.1), so prior to a release perhaps the open 4.x issues should perhaps be moved to no version (unscheduled?), and 4.x closed, to avoid confusion?

Would someone with more permissions in JIRA than I have like to do this clean up?

Michael Vorburger

unread,
May 16, 2017, 10:31:17 AM5/16/17
to op...@googlegroups.com, Michael Vorburger
On Tue, May 16, 2017 at 1:02 PM, Michael Vorburger <mi...@vorburger.ch> wrote:

On Tue, May 16, 2017 at 11:20 AM, <arunan.balasubramaniam@interlinksoftware.com> wrote:


Hi Michael,

thank you for holding off. Fixes for the two issues we wanted resolved are now on master.

cool

Regards,
Arunan



On Wednesday, May 10, 2017 at 10:28:11 AM UTC+1, arunan.bala...@interlinksoftware.com wrote:


Hi Michael,

we are in the middle of porting our stack to Karaf 4.1.1 and would like to get two patches upstreamed into pax exam if possible; I've not yet got access to the OPS4J Jira to update 815.

https://ops4j1.jira.com/browse/PAXEXAM-723 - my colleague put up a patch https://github.com/NetNow/org.ops4j.pax.exam2/commit/5dc57cb012306b5df53b98680b67c34a9b4d47d2?diff=unified that I think got lost in the noise. The title of the ticket suggests a breaking change to the feature, but the suggested patch has an opt-in option instead.
https://ops4j1.jira.com/browse/PAXEXAM-815 - there is a branch at https://github.com/NetNow/org.ops4j.pax.exam2/tree/configure-karaf-logging-by-backend which has allowed me to get logging from the console when using log4j2.

These would be handy for us. I also think that more and more people are going to hit 815 as they move to Karaf 4.1.x versions, since it uses log4j2. I would be happy to action any feedback regarding these two patches in order to get them merged and released.

Regards,
Arunan


On Monday, May 8, 2017 at 2:41:02 PM UTC+1, Michael Vorburger wrote:
Hello,

In order to be able to benefit from https://ops4j1.jira.com/browse/PAXEXAM-740 in a downstream project, I would be interested in a Pax Exam release some time. It's not super urgent, but was hoping for maybe the next week or two.. if this fits with other ongoing issues on https://ops4j1.jira.com/projects/PAXEXAM?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page&status=unreleased - what are your plans?

Or can I go ahead and just push a pax exam to central as-is now? Latest published is 4.10.0, so shall we have a 4.10.1 next, as there seem to be only 4 small fixes since the 4.10.0. That would be in line with the current 4.10.1-SNAPSHOT in the pom.xml of master .. or do you instead want us to bump master to 4.11.0-SNAPSHOT now, to be in line with JIRA https://ops4j1.jira.com/browse/PAXEXAM-812 and https://ops4j1.jira.com/browse/PAXEXAM-740?

back to this point.. I still don't have permission to admin versions and set release dates / close / add new versions in JIRA (Achim?).

More importantly, it seems to me that the project's original intention probably is to release with bumps to the middle version number, not the last minor version, as this would allow patches in the future to the previous release version?

I've therefore just raised https://github.com/ops4j/org.ops4j.pax.exam2/pull/69 to bump master from 4.10.1-SNAPSHOT to 4.11.0-SNAPSHOT in, with the intention of releasing what is now on master as 4.11.0.

I've just pushed 4.11.0 to Maven central (NB it sometimes takes a moment to propagate).

Could someone with JIRA administration permissions "release" that version in JIRA, and open a 4.12.0 version?

I'll be sending out the usual short announcement email tomorrow in a new thread.

Achim Nierbeck

unread,
May 16, 2017, 2:59:35 PM5/16/17
to op...@googlegroups.com, Michael Vorburger
Done :) 

I'm gonna see what extra roles are needed so you can do that your own :) 

regards, Achim 


--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages