PAX Wicket 4 (moving to wicket 8)

[nino martinez wael]

Hi 

Over 2 months ago I made the last changes to the 4.x.y branch[1] to support wicket 8. I cannot get the "bare" felix tests to work (I seem to be missing some dependency, which I cannot figure out)..

The question is, should I just disable the the test, as there are no horison on it getting to work and release what we have..? If not, how should we get the broken felix tests to work, i'm pretty sure its some dependency thing that's out of sync.

[1]https://github.com/ops4j/org.ops4j.pax.wicket/tree/v4.x.y

Regard Nino

[Christoph Läubrich]

Hi nino,

the goal should be to more test per release and not to disable existing ones.

It is a little hard to help without exact informations, what is exacly the problem with the test:

 - What tests(s) are affected
 - What fails (e.g. what bundles do not resolve etc.)
 - Whats your enviroument (java + maven version)
 - Have you tried to clear your maven-repro + rund a clean install

regards
Christoph

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[nino martinez wael]

Yes I agree Christoph, thats why I wrote the list..Nothing came out of it though..

Se here:

https://groups.google.com/forum/?hl=en#!topic/ops4j/ahQOfLYXmAM

All you are asking for are described there. And yes I have tried cleaning/deleting my local repo and run a clean install.

Thanks for your input.

regards Nino

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---

You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Best regards / Med venlig hilsen 

Nino Martinez

[Christoph Läubrich]

I can try to take a look at it next week, just wondering ig the
WhiteboardService is needed for the test at all? Pax Wicket does only
require a simple http-service so you can even try to drop pax-web and
use the (simpler) felix-http service for this use case.

Am 24.05.2017 10:31, schrieb nino martinez wael:
> Yes I agree Christoph, thats why I wrote the list..Nothing came out of
> it though..
>
> Se here:
>
> https://groups.google.com/forum/?hl=en#!topic/ops4j/ahQOfLYXmAM

> <https://groups.google.com/forum/?hl=en#%21topic/ops4j/ahQOfLYXmAM>

[nino martinez wael]

Time has passed again.. Im wondering if it would be okay to release an experimental or milestone release with the felix test disabled?

regards Nino

[Christoph Läubrich]

Hi nino,

sadly I have not had time to take a look, did you tried with the felix http-service in the mean time?

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.

[nino martinez wael]

I have not, will do so tomorrow.. No hassle, it's just fine.. Thought an experimental release could be okay? 

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---

You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.

[nino martinez wael]

OK i've removed the pax web dependency from the test.. But now I am getting this, could it be because of blueprint and springdm depends on pax-web somehow?:

org.ops4j.pax.wicket.service[org.ops4j.pax.wicket.internal.extender.PaxWicketBundleListener] : Class 'org.ops4j.pax.wicket.spi.blueprint' was found via bundle javax.activation.DataHandlerDataSource's resource path, but classloader can't load it (is the jar file

 corrupted or a dependant optional dependencies not resolved?)

org.ops4j.pax.wicket.service[org.ops4j.pax.wicket.internal.extender.PaxWicketBundleListener] : Class 'org.ops4j.pax.wicket.spi.blueprint' was found via bundle javax.activation.DataSourceDataContentHandler's resource path, but classloader can't load it (is the j

ar file corrupted or a dependant optional dependencies not resolved?)

org.ops4j.pax.wicket.service[org.ops4j.pax.wicket.internal.extender.PaxWicketBundleListener] : Class 'org.ops4j.pax.wicket.spi.blueprint' was found via bundle javax.activation.ObjectDataContentHandler's resource path, but classloader can't load it (is the jar f

ile corrupted or a dependant optional dependencies not resolved?)

org.ops4j.pax.wicket.service[org.ops4j.pax.wicket.internal.extender.PaxWicketBundleListener] : Class 'org.ops4j.pax.wicket.spi.blueprint' was found via bundle javax.activation.SecuritySupport's resource path, but classloader can't load it (is the jar file corru

pted or a dependant optional dependencies not resolved?)

org.ops4j.pax.wicket.service[org.ops4j.pax.wicket.internal.extender.PaxWicketBundleListener] : Class 'org.ops4j.pax.wicket.spi.springdm' was found via bundle javax.activation.DataHandlerDataSource's resource path, but classloader can't load it (is the jar file

corrupted or a dependant optional dependencies not resolved?)

[Christoph Läubrich]

This really sounds strange, I'll take a look now.

I think you can always releas a RC version or simply build your own local one.

--

--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.

[Christoph Läubrich]

Found the issue: The logmessage simply has wrong parameter order and a missleading logger name, beside this this has no impact on the code since we scan the classpath for pax-wicket annotations

The real cause for the waring is: https://stackoverflow.com/questions/12142872/java-lang-classformaterror-absent-code-attribute-in-method-that-is-not-native-o

I will add code that ignores javax. classes becuas ethe will never carry pax wicket annotations.

Am 14.06.2017 10:52, schrieb nino martinez wael:

--

[Christoph Läubrich]

Hi Nino,

I'm currently trying to upgrade the master from Wicket 6-->7 to see what have changed and will then go on to 7-->8 I think this might bring some light into this issue.

Am 22.05.2017 06:55, schrieb nino martinez wael:

[nino martinez wael]

Ok great, let me know If I can do something.. 

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---

You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Christoph Läubrich]

Hi Nino,

I created the branch v3.1.x, it is working so far beside the karaf tests
fail with

Server returned HTTP response code: 401 for URL:
http://localhost:8181/issues

any idea what is causing this? If we have sorted this out I think we
should make this the 4.0 version and make wicket 8 a pax-wicket 5.0 version

[Christoph Läubrich]

I opened a bug to Wicket 8:
https://issues.apache.org/jira/browse/WICKET-6402 it seems they lost the
OSGi Manifest information in Wicket 8 what is bad. Beside thsi there
seem no API changes that influence Pax-Wicket so once Wicket 8 is
release we can raise the version range instead of supply a 5.0 version,
pax-wicket 4 will the support Wicket 7 + Wicket 8!

[nino martinez wael]

Ahh I see most of the changes where from 6.x to 7.x.. 

But what about the Websocket stuff, as I remember it has been changed alot in Wicket 8..?

On Mon, Jun 19, 2017 at 2:55 PM, 'Christoph Läubrich' via OPS4J <op...@googlegroups.com> wrote:

I opened a bug to Wicket 8: https://issues.apache.org/jira/browse/WICKET-6402 it seems they lost the OSGi Manifest information in Wicket 8 what is bad. Beside thsi there seem no API changes that influence Pax-Wicket so once Wicket 8 is release we can raise the version range instead of supply a 5.0 version, pax-wicket 4 will the support Wicket 7 + Wicket 8!

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

--- You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Christoph Läubrich]

As long as there are no API-breaks within Pax-Wicket it doesen't matter, client-code has to choose of course if the want 7 or 8, but I can only check this if Wicket adds OSGi-Headers, so sign up at the Wicket JIRA and vote for the issue ;-)

[nino martinez wael]

Hi Christoph

Looks like WICKET-6402 already are resolved?

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Christoph Läubrich]

Yep, I'll see if i can bulid a snapshot version to test with wicket 8, but first must sort out the strange karaf test failure, do you think you can take a look at those tests also?

You received this message because you are subscribed to the Google Groups "OPS4J" group.

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.

[nino martinez wael]

Hmm seems I do not have any issues with tests on karaf.. What was the problem specifically?

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Christoph Läubrich]

Have you checked out the branch v3.1.x? For me it fails the karaf test with a 401 (Unauthorized) for some reason .-(

[nino martinez wael]

I do have an problem on:

http://localhost:8181/blueprint/wiquery/

Wiquery seems to be discontinued. And it only supports wicket 7.. Maybe we should abandon support for it.?

To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[nino martinez wael]

yes I am on 3.1.x 

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[nino martinez wael]

just made a single commit..

[Christoph Läubrich]

Didn't know we have an example/test for it :-D

I'll take a look on this on friday...

[Christoph Läubrich]

The test are running fine now :-)
I'll try to prepare a release of a 4.0.0 Version for Wicket 7 then we
can move on to wicket 8 as a next step

[nino martinez wael]

ok great :)

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

--- You received this message because you are subscribed to a topic in the Google Groups "OPS4J" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ops4j/A3x7_4ktoqk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ops4j+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[nino martinez wael]

Just wondering how this is comming along?

-regards Nino

[Christoph Läubrich]

Hi,

I currently wait to getting right to pusch to the sonar to complete the
4.x release and will then prepare for 5.0 :-)

[Christoph Läubrich]

Hi Nino,

I just pushed a Wicket-8 supporting version of pax-wicket
(https://ops4j1.jira.com/browse/PAXWICKET-486) to the master, the only
thing that is needed is adjusting the karaf-test, can you help with
that? I think it just needs to add some of the new dependencies, I added
the following to the "normal" integration tests:


provision(mavenBundle().groupId("org.slf4j").artifactId("slf4j-api").versionAsInProject()),

provision(mavenBundle().groupId("org.apache.commons").artifactId("commons-collections4").versionAsInProject()),

provision(mavenBundle().groupId("org.ops4j.pax.url").artifactId("pax-url-wrap").versionAsInProject()),

provision(wrappedBundle(mavenBundle().groupId("org.danekja").artifactId("jdk-serializable-functional").versionAsInProject())),

provision(wrappedBundle(mavenBundle().groupId("com.github.openjson").artifactId("openjson").versionAsInProject())),

provision(mavenBundle().groupId("org.slf4j").artifactId("slf4j-simple").versionAsInProject().start(false)),

can you take a look? As soon as this is done I think we can release a
5.0.0.RC1, we should release the final Version when Wicket has release
Wicket8.