AspectJ Maven Plugin

[Karl Heinz Marbaise]

Hi,

I have tried to build AspectJ Maven Plugin with JDK 9 which will fail mostly all integration tests..

furthermore I've tried to update aspectJ version to 1.9.1 but with the same result...

Can we do more ? 

Kind regards

Karl Heinz Marbaise

[Dan Tran]

there is PR to get java 9 working but could not get any mojo dev to push it.  An user ended up to fork  and release it

https://github.com/mojohaus/aspectj-maven-plugin/issues/24

-D

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To post to this group, send email to mojoha...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/d4c03b7e-9a74-43c8-a828-a527859a4267%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Karl Heinz Marbaise]

Hi,

I've merged one branch back to master..

lets see what happened...

If it helps I can cut a release ...

During the VOTE someone should check if it works with JDK 9..if not we can fix and cut a new release afterwards..

Kind regards

Karl Heinz Marbaise

[Dan Tran]

i am sure lots of users will jump in to help with testing. I don't have any java 9 project to test yet

Thanks 

-D

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/354dfa27-fc01-4e7d-97e7-bb0ca313090f%40googlegroups.com.

[mikael petterson]

I posted in https://github.com/mojohaus/aspectj-maven-plugin/issues/24

We cannot get the latest codebase to work with java 10 compliance.

//mikael

[David Karlsen]

Hi - sorry for not responding to the thread that was directly to mojo-members - the mailing list is a lot better place.

I've been - very lowbudget - maintaining this until now - but I am very swamped at the moment - if others could chip in in would be great. 

Last PR I merged was: https://github.com/mojohaus/aspectj-maven-plugin/pull/37 - which I should probably not have done as the CI build @travis started to fail https://travis-ci.org/mojohaus/aspectj-maven-plugin/builds - that can be rolled back - but it was supposed to fix the JDK9 compat (I guess now 10/11 is more relevant).
There is some discussion going on in that PR that there are some invalid tests.

Maybe the better option is to roll master back into a working state, get the full fix in a PR and apply that?

Are anybody willing to take over maintainership - maybe some of the PR authors could join mojohaus?

Again - sorry for the silence and latest PR merge mess - where do we want to go with this - something needs to be done before java 11 is GA. 

[mikael petterson]

Hi David

Glad to hear you are alive :-)

Which list should we use?

I think Tomaž Cerar tomaz...@gmail.com is willing to support

A quote I got from him.

"

If needed I can volunteer to help with maintaining the plugin and

cutting the release but I would need permissions to do so.

"

I can also assist since we have an interest in the plugin. And there could be another person that could also assist ( just need to double check).

What do you need from all of us to be able to contribute ( I mean in terms of access rights)?

I mentioned in here:  https://github.com/mojohaus/aspectj-maven-plugin/issues/24

what kind of exception the a fork of the release gives.

We need to make it work for jdk 10/11 so jdk 9 is not urgent.

I think it would be good to revert the fix since it does not solve the problem for jdk10 ( as in issue 24).

Those are our 22 cents of input.

br,

//mikael

[David Karlsen]

This one

--
You received this message because you are subscribed to a topic in the Google Groups "mojohaus-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mojohaus-dev/dkCC-L4dUyk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to mojohaus-dev...@googlegroups.com.

To post to this group, send email to mojoha...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/f191e3fa-8f96-494e-ace8-99df9e48426b%40googlegroups.com.

[David Karlsen]

How can we onboard Tomaz to mojohaus so that he can maintain the plugin ?

--

You received this message because you are subscribed to a topic in the Google Groups "mojohaus-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mojohaus-dev/dkCC-L4dUyk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to mojohaus-dev...@googlegroups.com.
To post to this group, send email to mojoha...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/f191e3fa-8f96-494e-ace8-99df9e48426b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

--
David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen

[Tomaž Cerar]

Hey guys,

sorry for late reply (went to spam & had some issues with posting here)

I really don't mind with helping to maintain this plugin.

When it comes to building an testing master of aspectj-maven-plugin on JDK9/10/11 it wont work,

but changes there will allow user to override aspectj to make it work properly, for details on this

see https://github.com/mojohaus/aspectj-maven-plugin/pull/37#issuecomment-389111923

I did however made build work and most* tests passing on JDK 8/9/10 & 11.

which you can see at my fork https://github.com/ctomc/aspectj-maven-plugin/commits/jdk11

Where main changes are move to aspectj 1.9.1 which works better on JDK 9 as well as other changes need

to make tests pass properly.

Test "AnnotationProcessingOutput" had to get ignored, as if fails with newer version of aspectj.

Root cause is somewhere in relation google auto-value annotation-processor <--> ecj.

I did try with combination of different versions of both, but couldn't find working solution.

I can create a PR with my (cleaned up) changes if needed and if that helps with release process itself.

This branch is bases for internal release in our company, so we can now compile our code on JDK 11.

--

tomaz

[Phil Clay]

Has there been any movement on releasing aspectj-maven-plugin with Java 11 support?

aspectj added java 11 support in 1.9.2 last week.

I'm anxiously awaiting Java 11 support in aspectj-maven-plugin to take advantage of it.