Which face to configure for flags (Magit 1.2.0 vs. zenburn theme)

[Howard Lewis Ship]

I'm using Magit inside Emacs.app 24 on a Mac and the zenburn theme.

When I select an option (such as -r with Pull action), I don't see any visual feedback that I've selected the switch. It is present when not using zenburn, so I'm assuming there's a face to customize for this purpose ... but I don't know what face to customize. None of the options in the magit-faces customization group seemed appropriate.

Actually I was just working on this, there's a very subtle change in color ... intuitively, "Magit Item Mark Face" seems like the right face, but customizations of it don't seem to affect it.

Here's what it looks like on my system:

I'd love to get the right side (-r selected) face to be more immediately visible ... underlines, bold, bright ... something!

So ... what is the correct face to modify, or is there a bug that Magit and Zenburn don't work together well here?

Thanks,

Howard

[markhepburn]

Which version of zenburn are you using?  I'm aware of two; there's this one that el-get installs by default: https://github.com/djcb/elisp/tree/master/themes

I installed that recently and noticed a few issues.  I switched back to this one and haven't had a problem since:

https://github.com/bbatsov/zenburn-emacs

/Mark.

[Howard Lewis Ship]

I've tried both versions of zenburn, and a few other styles as well ... none of them seem to make much of a difference.

--
 
---
You received this message because you are subscribed to a topic in the Google Groups "magit" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/magit/bNCQFDcpBV8/unsubscribe?hl=en.
To unsubscribe from this group and all its topics, send an email to magit+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

[Phil Jackson]

Looks like font-lock-warning-face is hard-coded in magit-key-mode.el.

Should be a simple fix to make it a customisable face if anyone's up

for the task?

Cheers,

Phil

--
 
---
You received this message because you are subscribed to the Google Groups "magit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to magit+un...@googlegroups.com.

[jonasbe...@gmail.com]

I have created an issue for this (https://github.com/magit/magit/issues/737) and intend to work on it soon after the next release (due soonish).

Jonas