Applied. Thanks.
10.04.2013 21:41, Stanislav Galabov О©╫О©╫О©╫О©╫О©╫:
> It's done. If you wish you can merge it into master.
>
> Best wishes,
> Stanislav
>
> On Apr 10, 2013, at 8:38 PM, "
serj.k...@gmail.com" <
serj.k...@gmail.com> wrote:
>
>> No problem. If it's suitable for you - do it.
>>
>> 10.04.2013 21:21, Stanislav Galabov О©╫О©╫О©╫О©╫О©╫:
>>> Hi Serj,
>>>
>>> I wouldn't say it's very important, it is more "nice to have" than anything.
>>> Moreover the overhead of checking whether ld supports --version-script in configure is not that big, so I don't see a reason not to leave it in. It will be good to know that somewhere down the road we do not have to revisit this.
>>>
>>> I am not sure whether all versions of gcc we may run into support the visibility attribute, so we may have to implement a similar mechanism in configure to detect this, so again - additional work will be needed, however little it is... I think I prefer to use the method I have already implemented if/when needed... What do you think?
>>>
>>> Best wishes,
>>> Stanislav
>>>
>>> On 10.04.2013, at 19:44, "
serj.k...@gmail.com" <
serj.k...@gmail.com> wrote:
>>>
>>>> Hi Stanislav
>>>>
>>>> Is it really important? For example default plugin has no symbols to hide.
>>>> Anyway I have used the following mechanism to hide symbols:
>>>>
>>>> #ifndef SYM_HIDDEN
>>>> #define SYM_HIDDEN __attribute__((visibility("hidden")))
>>>> #endif
>>>>
>>>> SYM_HIDDEN aud_info_t _fs_aud_info = NULL;
>>>>
>>>> Another mechanisms were less suitable
>>>>
>>>>
>>>> v Galabov О©╫О©╫О©╫О©╫О©╫:
>>>>> Hi Serj,
>>>>>
>>>>> Ok, thanks. I've updated xml-examples/lua/*.xml to reflect all this :-)
>>>>> Also, I think I finally have a solution for hiding plugin symbols properly - works on FreeBSD, should work on Linux too.
>>>>> It consists of the following:
>>>>> In
configure.ac we check if LD supports --version-script parameter. If so - it sets an AM_CONDITIONAL (HAVE_LD_VERSION_SCRIPT), which is then used in
module.am of each plugin that wants to only export relevant symbols. If the conditional is true - we use version scripts. If it is false - we use a symbol file, which simply lists all symbols we wish to export (one per line). The latter option doesn't work on FreeBSD for some reason, but it seems as a good fallback.
>>>>>
>>>>> Best wishes,
>>>>> Stanislav
>>>>>
>>>>> On Apr 10, 2013, at 3:36 PM, "
serj.k...@gmail.com" <
serj.k...@gmail.com> wrote:
>>>>>
>>>>>> I'm totaly forget everything :)
>>>>>> The new implementation of default_builtin is <HOOK name="action" builtin="lua@lua"/>. It works.
>>>>>> The default_plugin will be removed.
>>>>>>
>>>>>> The lua plugin and "Lua hello world" works for me.
>>>>>>
>>>>>> 10.04.2013 16:26, Stanislav Galabov О©╫О©╫О©╫О©╫О©╫:
>>>>>>> Thanks.
>>>>>>>
>>>>>>> In the meantime, have you had a chance to play a little with the Lua plugin? If so, does it work ok for you?
>>>>>>>
>>>>>>> Best wishes,
>>>>>>> Stanislav
>>>>>>>
>>>>>>> On Apr 10, 2013, at 3:16 PM, "
serj.k...@gmail.com" <
serj.k...@gmail.com> wrote:
>>>>>>>
>>>>>>>> I've forget about default_builtin. :) Thanks for the reminder. I thought it's already implemented. I'll implement it today.
>>>>>>>>
>>>>>>>> 10.04.2013 15:10, Stanislav Galabov О©╫О©╫О©╫О©╫О©╫: