Pull Request: 882 seperate Cancel permission from Build permission for JENKINS-14713

[Hangsu Ma]

Hi All,

Please let me know what do you think on this!

The reasons:

• On Jenkins security authorization matrix, Build and Cancel are listed as different items in same category, this normally implies they are independent permissions. But the current behavior is: Build permission implicitly grants Cancel permission, I find this quite confusing from admin point of view.
  
• In my company, we have over 20 dev teams and 400+ jobs running on Jenkins, too many build and cancel games going on every day.
  

From the look of this JIRA, I am not the only one out there having these problem:

https://issues.jenkins-ci.org/browse/JENKINS-14713

The change:

https://github.com/jenkinsci/jenkins/pull/882

They are simple enough change, however, after this change is merged, new version of Jenkins will not allow user with Build permissions only to Cancel build, this is going to have impact on jenkins users.

The script:

In order to address this, scripts below are developed to make configuration compatible, this will make sure Jenkins doesn't behaviour differently after the fix from user point of view.

https://wiki.jenkins-ci.org/display/JENKINS/Grant+Cancel+Permission+for+user+and+group+that+have+Build+permission

The LTS branch:

My company only use LTS Jenkins version. I am wondering how long it normally take for a new change to make into a LTS?

[Nickolay Rumyantsev]

Hi Hangsu,

I've recently faced the same issue using Jenkins 1.543. Is there any progress with your pull-request?

Regards,

Nickolay

среда, 24 июля 2013 г., 20:40:04 UTC+4 пользователь Hangsu Ma написал:

[Hangsu Ma]

Hi Nickolay,

No progress on my pull request.

below are the step i use do local jenkins build, you can follow it and build a jenkins.war with this change, the script is for 1.509 which is last LTS, u can change it to any version you want.

You can download 1.509.4 I built here:https://www.dropbox.com/s/89hptyzk0vqsy2g/jenkins.war

git clone https://github.com/hangsuma/jenkins
cd jenkins
git remote add upstream https://github.com/jenkinsci/jenkins
git fetch upstream
git checkout master
git rebase upstream/master

git checkout jenkins-1.509.4(replace with current Jenkins LTS)
git cherry-pick 1d0be0016bc498810579d8494c87bbd2922893b3
git commit -C
mvn versions:set -DnewVersion=1.509.4-SOMETHINGTOSHOWITSALOCALBUILD -DgenerateBackupPoms=false -DprocessDependencies=false -DprocessPlugins=false
then modify war/pom.xml and test/pom.xml replace {project.verion} with 1.509.4(replace with current LTS version) for jenkins modules in dependencies section
mvn clean
mvn package -Dmaven.test.skip=true

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/pld0yH6_fdo/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.