From sidebar <l:pane> to <l:divpane> ....

[Tom Fennelly]

Hi.

I've been looking to see if we could replace the current <l:pane> based panels with <div> based alternatives.  I think this will help us style the panels better + I think they will work better (Vs tables) with the new layout.

Basically what I've done so far (https://github.com/tfennelly/jenkins/compare/JENKINS-23810) is:

1. Created a new set of tags (<l:divpane>, <l:divpaneRow> and <l:divpaneCell>) to replace the current <l:pane> tag.
   
2. Updated the Build Queue, Executors and History panes to use this approach.
   
3. Can see it here: http://166.78.9.27:8080/
   

Examples of what they look like... 

Intentionally looks fairly similar to current panes but we can sex them up some more if we want (easier with divs).

I can see at least 22 plugins/components using this tag atm.  Do we try migrate them all (then we'd need a "shim" type tagset to support BC), or leave them using the current pane?

Comments/feedback please.

Regards,

T.

[Mike Chmielewski]

Only thing I would change is making the rows for each executer more distinct from those above and below it.

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

 

--

Mike Chmielewski

co...@mikec.123mail.org

[Stephen Connolly]

I want to set these to be collapsed by default if the number of executors is above some threshold (as this will improve responsiveness) 

As long as you don't interfere with that aim, I'm good

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
Sent from my phone

[domi]

Not only collaps after a number of executers, but actually make the whole thing disappear and only show the ones currently executing a build. ...and some people don't even wanna see the executing ones...

[Mirko Friedenhagen]

+1 for completely collapsing the whole stuff (or even make this a separate page?) maybe when a job takes longer as expected the collapsed build queue should give a hint.

Regards
Mirko
--
Sent from my mobile

[Tom Fennelly]

So how is this controlled atm?  I don't see anything to this effect in the templates I modified.  I've really just replaced table based layouts with div based layouts.

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/jzTgl9hEdPM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.