New Plugin: SAML Plugin

82 views
Skip to first unread message

Ben McCann

unread,
Aug 6, 2014, 4:35:20 PM8/6/14
to jenkin...@googlegroups.com
Hi,

I created a SAML 2.0 Authentication plugin:

My GitHub ID is benmccann

Thanks,
Ben

Ben McCann

unread,
Aug 7, 2014, 2:54:32 PM8/7/14
to jenkin...@googlegroups.com
Hi,

Just wanted to follow up on this and see if there was anything I needed to do to have this downloadable from the Jenkins plugin registry. There's no plugin currently supporting SAML 2.0, so I think this will be a very helpful addition.

Thanks,
Ben





--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/M4DrLUhpUSk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
about.me/benmccann

Ben McCann

unread,
Aug 8, 2014, 1:21:04 PM8/8/14
to jenkin...@googlegroups.com

Hi,

Any thoughts on this?

Thanks,
Ben

Christopher Orr

unread,
Aug 8, 2014, 4:07:37 PM8/8/14
to jenkin...@googlegroups.com
Hi there,

Your plugin has been cloned here, and the GitHub ID you mentioned also
has commit access:
https://github.com/jenkinsci/saml-plugin

If you could follow convention and remove the "-plugin" suffix from the
artifactId in pom.xml, that would be great. The URL to the licence
would also need to be changed (not that it's usually necessary, AFAIK).

Also the "All rights reserved" comments to your company in the source
files seems like it maybe conflicts with the fact that the code is meant
to be Apache licensed? (Not that I'm a lawyer)

In any case, you just need to follow the steps here to make a release:
https://wiki.jenkins-ci.org/display/JENKINS/Hosting+Plugins

Welcome aboard :)

Regards,
Chris


On 08/08/2014 07:20 PM, Ben McCann wrote:
> Hi,
>
> Any thoughts on this?
>
> Thanks,
> Ben
>
> On Aug 7, 2014 11:54 AM, "Ben McCann" <b...@benmccann.com
> <mailto:b...@benmccann.com>> wrote:
>
> Hi,
>
> Just wanted to follow up on this and see if there was anything I
> needed to do to have this downloadable from the Jenkins plugin
> registry. There's no plugin currently supporting SAML 2.0, so I
> think this will be a very helpful addition.
>
> Thanks,
> Ben
>
>
>
>
> On Wed, Aug 6, 2014 at 1:35 PM, Ben McCann
> <benjamin...@gmail.com <mailto:benjamin...@gmail.com>>

Ben McCann

unread,
Aug 8, 2014, 7:00:46 PM8/8/14
to jenkin...@googlegroups.com
Great! Thank you so much.

I've made the changes you've requested and released 0.1. I think... It's not showing up yet as available for download and the wiki still says No Information For This Plugin. Perhaps it just takes awhile to appear due to some caching or something

Is there anything I should do to have the plugin listed here: https://wiki.jenkins-ci.org/display/JENKINS/Plugins ?  It looks like it has to be tagged as a user plugin, but I'm not sure where those tags are managed.

Btw, it seems like not a great idea that the update site is http://updates.jenkins-ci.org/update-center.json. That seems like something that should really, really have HTTPS enabled on it.

Thanks!
Ben






    wrote:

        Hi,

        I created a SAML 2.0 Authentication plugin:
        https://github.com/connectifier/jenkins-saml-plugin

        My GitHub ID is benmccann

        Thanks,
        Ben
--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/M4DrLUhpUSk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Ben McCann

unread,
Aug 9, 2014, 2:46:35 PM8/9/14
to jenkin...@googlegroups.com
I just filed two bugs for the https issue. I have to say I am quite concerned this is an issue and that there are over 50 open items listed as critical security issues in the bug tracker.
https://issues.jenkins-ci.org/browse/JENKINS-24190



Ben McCann

unread,
Aug 9, 2014, 2:56:03 PM8/9/14
to jenkin...@googlegroups.com
I don't see my plugin yet in the two sites mentioned on the wiki. It's been almost 24 hours and it said they should show up within 6, so I think somethings wrong.

When I ran "mvn release:prepare release:perform" it uploaded the files and I can download them all:

Any suggestions?

Thanks,
Ben


Bruno P. Kinoshita

unread,
Aug 9, 2014, 3:03:12 PM8/9/14
to jenkin...@googlegroups.com
Hi Ben, 

I think your plugin was uploaded to the snapshot repository. 

Take a look at any of this previous threads 


Hope that helps
Bruno


From: Ben McCann <b...@benmccann.com>
To: jenkin...@googlegroups.com
Sent: Saturday, August 9, 2014 3:56 PM
Subject: Re: New Plugin: SAML Plugin

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

Ben McCann

unread,
Aug 11, 2014, 7:38:13 PM8/11/14
to jenkin...@googlegroups.com
Awesome! Thank you so much for the help. That looks like it worked, so I'll let some time pass and see if it shows up.

I looked into fixing this so that other don't run into this issue. Looks like we just need to update org.jenkins-ci.plugins:plugin:1.575 to use org.jenkins-ci:jenkins:1.34 instead of org.jenkins-ci:jenkins:1.33.  It looks like this change has already been made and so hopefully once the next version of the plugin is released this will no longer be an issue.

Thanks again,

-Ben




To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Ben McCann

unread,
Aug 18, 2014, 12:39:04 PM8/18/14
to jenkin...@googlegroups.com
I still have one more question about setting up my plugin.

Ben McCann

unread,
Aug 18, 2014, 12:41:10 PM8/18/14
to jenkin...@googlegroups.com
Oops. DIdn't mean to hit send on that last email.

I still have one more question about setting up my plugin

The plugins wiki page (https://wiki.jenkins-ci.org/display/JENKINS/Plugins#Plugins-Authenticationandusermanagement) lists all the plugins and mine is not appearing yet.

Here is the section it should appear in:

Authentication and user management
{contentbylabel:plugin-user|excerpt=true|showLabels=false|maxResults=100|showSpace=false|sort=title}

How do I add the label "plugin-user" to my plugin so that it will appear here?

Thanks,
Ben



domi

unread,
Aug 19, 2014, 1:34:28 AM8/19/14
to Jenkins Developers
Ad the bottom of the page you can add labels - I added “plugin-user” for you and the plugin is now showing up in the overview page
Domi



Any suggestions?

Thanks,
Ben





To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

For more options, visithttps://groups.google.com/d/optout.



-- 
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/M4DrLUhpUSk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Ben McCann

unread,
Aug 19, 2014, 1:36:39 AM8/19/14
to jenkin...@googlegroups.com
Awesome. Thank you!

Prabhat Singh

unread,
Feb 12, 2017, 11:50:00 PM2/12/17
to Jenkins Developers
Hi Ben,

I am trying this plugin for ADFS integration SAML2.0, user able to login but says no overall read rights.
Do you have any documentation around integration with ADFS?

Regards
Prabhat
Reply all
Reply to author
Forward
0 new messages